Skip to content

improvement(ui): reuse chips for panel selection actions - #8166

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-workflow-panel-tabsfrom
codex/overrides-panel-actions
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-workflow-panel-tabsfrom
codex/overrides-panel-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Workflow tabs and terminal Input/Output selection now use the existing Chip active treatment. The local PanelTabButton wrapper and export are removed. Header menu/chat buttons use the shared 28px regular icon size.

Tab handlers, hydration guards, data attributes, visibility conditions and mounted panel content are unchanged. Intentional visual changes: tabs 28→30px and labels 12→14px, standard chip corners and selected fill, and header actions 30→28px.

Validation: workspace types, import checks, mandatory API validation, lint, full EMCN suite and 29consumer tests. Source-backed light/dark/selected/focus/enlarged-text fixture screenshots will be attached; live authenticated workflow behavior was not exercised in the browser.

External full audit: 739→721 findings; all 18 targeted overrides removed, no new findings. Diff checker clean against the actual base.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 10:07pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the shared controls preserve the required interaction semantics and no stale references or concrete regressions remain.

Summary

This PR standardizes workflow-panel and terminal selection controls on the shared Chip component, removes the obsolete local tab-button wrapper, and adopts the shared 28px icon-action sizing for panel header controls.

  • Preserves existing tab handlers, hydration guards, data attributes, visibility conditions, and mounted panel content.
  • Uses Chip active for Chat, Toolbar, Editor, Output, and Input selection.
  • Removes the unused PanelTabButton implementation and export.
  • No actionable correctness, accessibility, security, or repository-rule regression was identified.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse chips for panel s..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after at 85c350c. Existing Chips replace the local tab wrapper and terminal selection styles. Source-backed fixtures with local state; live authenticated workflow behavior was not exercised.

Intentional differences: tabs 28→30px, labels 12→14px, shared selected fill/corners; header icon actions 30→28px. Click/keyboard selection was exercised. Product hydration guards, data attributes and mounted content are unchanged.

Light — before left / after right:
clipboard

Dark — before left / after right:
clipboard

Controls — 2× enlarged crop:
clipboard

This branch was previously deployed

1 inactive deployment
Preview 85c350c7 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant