Skip to content

refactor(ui): use Chip for PII configuration action - #8173

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-modal-fieldsfrom
codex/overrides-pii-action
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-modal-fieldsfrom
codex/overrides-pii-action

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Use the existing outlined, full-width Chip for the PII configuration trigger, with its icon and trailing selection count slots. This removes the local Button colour, padding, border and radius overrides.

The existing modal, grouped selection, Select all/Clear semantics and search-driven opening/scrolling are unchanged. Intentional visual differences are the standard 30px chip height, 8px corners and shared outlined/icon/text treatment.

Validation: workspace type/import/API/lint checks, complete EMCN suite and 21 consumer tests pass. Both external linters ran against the actual base; the diff checker is clean. Browser checks use the actual components with local store/search context, covering selection summaries, disabled state, keyboard opening and search scrolling. Light/dark and narrow/enlarged-text screenshots are attached separately; no live backend persistence or PII service run.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 10:29pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable regressions identified.

Summary

This PR replaces the locally styled PII configuration Button with the canonical outlined, full-width Chip.

  • Preserves the existing modal open handler and disabled state.
  • Uses the Chip’s standard leading-icon and trailing-adornment slots.
  • Leaves selection, search, scrolling, and modal behavior unchanged.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse chip for PII conf..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after at bacc6a4. Actual GroupedCheckboxList components with local store/search context. Individual selection, Select all, Clear, none/some/all summaries, disabled state, keyboard opening and search scrolling were checked. No live persistence or PII service run.

Intentional differences: standard 30px Chip height, 8px corners and shared outlined/icon/text treatment. The selection modal is unchanged.

Light — before left / after right:
clipboard

Dark — before left / after right:
clipboard

Trigger — 2× enlarged crop:
clipboard

@waleedlatif1
waleedlatif1 merged commit a820bbb into codex/control-fix-modal-fields Sep 23, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-pii-action branch September 23, 2026 02:13

This branch was previously deployed

1 inactive deployment
Preview — bacc6a4a Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants