fix(knowledge): settle detach reservations when a knowledge base is purged by waleedlatif1 · Pull Request #8184 · simstudioai/sim

waleedlatif1 · 2026-09-23T00:53:39Z

Summary

Purging a soft-deleted knowledge base cascaded away a detached connector together with its detach_reserved_bytes, the kept bytes charged to the workspace at removal. The pending detach job then found no knowledge base and settled nothing, so the charge stayed on the workspace and payer ledgers
Retention cleanup now calls settleDetachedConnectorReservations after the documents are hard-deleted and before the knowledge base rows are deleted. Per knowledge base, in one transaction, it locks the base then its detached connectors with a non-zero reservation (same order as the detach job), applies the detach job's own settlement (refund a positive remainder, admitted charge for an overdraft; now one shared helper), and zeroes the reservation so a retried purge or a detach run that still reaches the connector settles nothing twice
Test drain helper now picks the oldest pending outbox row instead of any row
Unfilled-projection fixture writes its Tin row with the base token and lexeme stream the projection trigger uses, so it scopes correctly under real Tin as well as the shim
scripts/test-knowledge-acls.ts also runs the 0021 projection source/ACL postgres test, since its setup already applies 0021
Purge settles overdrawn detach reservations before deleting documents (usage floors at zero) and the remaining reservations after them, so a partial deletion never leaves the ledger out of step
A connector detach pauses (without spending retries) while its knowledge base is deleted, so no release can interleave with the purge; a restore resumes it
Fix a flaky memory checkpoint test: tampering overwrote the auth tag with a fixed value, a no-op when the tag already ended with it; it now always changes the last hex digit

Type of Change

Bug fix

Testing

New purged-detach-reservation.integration.ts (3 tests, real Postgres), wired into the CI knowledge integration step: detach reserves, one bounded run releases part of the source, purge runs; ledger ends at 0 and the late detach job leaves it there. Also covers the zeroing (settle twice, then drain) and the overdraft branch
Mutation checks: dropping the cleanup call leaves 198 bytes on the ledger (1 red); dropping the zeroing turns 2 red; dropping the overdraft branch turns 1 red
cleanup-soft-deletes.test.ts 27/27 (new ordering test goes red without the call); lib/knowledge/connectors unit tests pass; storage-accounting, search-source-progress, unfilled-projection-source integration pass (32/32 with the new file); 0016 + 0021 postgres tests 23/23
bun run lint, bun run check:audits, apps/sim type-check pass

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…urged - Retention purge settles a detached connector's remaining detach_reserved_bytes (same lock order and settlement branches as the detach job) and zeroes it before the knowledge base delete cascades the connector away - Test drain helper picks the oldest pending outbox row - Unfilled-projection fixture writes its Tin row the way the projection trigger does - Knowledge ACL harness also runs the 0021 projection source/ACL postgres test

vercel · 2026-09-23T00:53:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 23, 2026 1:30am UTC

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-23T00:57:21Z

Confidence Score: 5/5

The PR appears safe to merge; the previously reported accounting and concurrency issues are resolved, and no new actionable failures were found.

Summary

This PR settles detached-connector storage reservations as part of knowledge-base retention cleanup and prevents detach workers from releasing documents while their knowledge base is soft-deleted.

Settles overdrawn reservations before document deletion and remaining reservations afterward.
Pauses detach outbox work while the parent knowledge base is deleted, without consuming an attempt.
Nets per-base reservation settlement into one ledger operation and zeroes settled reservations.
Adds PostgreSQL integration coverage for purge, retry, overdraft, restore, and late-detach behavior.
Makes related integration fixtures and test helpers deterministic and extends migration-test coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  D[Detached connector reservation] --> O[Settle overdraft]
  O --> H[Hard-delete knowledge documents]
  H --> R[Settle remaining reservation]
  R --> K[Delete knowledge base and cascade connector]
  W[Detach outbox worker] --> C{Knowledge base deleted?}
  C -->|Yes| P[Defer without consuming attempt]
  C -->|Restored| X[Resume bounded document release]
  C -->|Purged| Z[Finish as obsolete]

_{Reviews (5) · Last reviewed commit: "fix(knowledge): pause a connector detach..."}

… amount

waleedlatif1 · 2026-09-23T01:01:30Z

@greptile

waleedlatif1 · 2026-09-23T01:01:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-23T01:01:36Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 9 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

…ts documents

… auth tag

waleedlatif1 · 2026-09-23T01:11:05Z

@greptile

waleedlatif1 · 2026-09-23T01:11:06Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-23T01:11:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 10 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

…nts and the rest after

waleedlatif1 · 2026-09-23T01:20:03Z

@greptile

waleedlatif1 · 2026-09-23T01:20:04Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-23T01:20:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

…deleted

waleedlatif1 · 2026-09-23T01:30:30Z

@greptile

waleedlatif1 · 2026-09-23T01:30:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-23T01:30:38Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

vercel Bot deployed to Preview September 23, 2026 00:55 View deployment