Skip to content

fix(knowledge): restore GitLab PAT setup and secret references - #8185

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/restore-gitlab-kb-secrets
Sep 23, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/restore-gitlab-kb-secrets

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Restore ordinary GitLab PAT setup for regular knowledge bases while preserving Search's source-permission requirements.
  • Reuse the shared secret input, picker, and reference highlighting for {{SECRET_NAME}} references. Resolve secrets after authorization, store encrypted token snapshots, and redact credentials from setup validation errors.
  • Document the setup and add regression coverage for the modal, secret resolution, and the full create/sync/search/edit flow.

Type of Change

  • Bug fix

Testing

  • 470 focused tests and 3 PostgreSQL integration tests passed. Integration tests use fixture GitLab responses and embeddings with real connector persistence, encryption, indexing, retrieval, and access checks.
  • Manually verified the actual modal and secret picker in a local preview with fixture data.
  • Validated the connector's read endpoints against GitLab's official API documentation.
  • App type-check, full repository lint, all 47 audits, API boundary validation, and generated-artifact checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 23, 2026 1:50am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding correctness or security findings.

Summary

Restores GitLab personal-access-token setup for regular knowledge bases while retaining stricter source-permission requirements for Search.

  • Adds workspace-access support for ordinary GitLab knowledge connectors.
  • Resolves personal or workspace secret references only after authorization and persists an encrypted token snapshot.
  • Redacts connector credentials from provider validation failures.
  • Reuses the shared secret picker and adds focused unit and integration coverage.
  • Documents GitLab PAT requirements and secret snapshot behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[GitLab PAT or secret reference] --> B[Authorize workspace access]
    B --> C[Resolve secret reference]
    C --> D[Validate GitLab configuration]
    D --> E[Encrypt token snapshot]
    E --> F[Persist connector]
    F --> G[Sync and index project content]
    G --> H[Apply knowledge-base workspace access]
Loading

Reviews (3) · Last reviewed commit: "fix(knowledge): reuse shared secret refe..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ea9e85f into staging Sep 23, 2026
26 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/restore-gitlab-kb-secrets branch September 23, 2026 01:54

This branch was previously deployed

1 inactive deployment
Preview 85f87922 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant