refactor(emcn): share resource row and tile chrome by BillLeoutsakosvl346 · Pull Request #8240 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T18:45:33Z

Summary

Move the repeated resource row and tile chrome into EMCN, with a CVA recipe for its existing icon treatments.
Keep SettingsResourceRow as a thin Next Link adapter and preserve the app's existing imports and navigation behavior.
Preserve row, tile, trailing-control, disabled, hover, and focus geometry.

Base and design review

Targets current staging at d8e7e923a2. The local design diff check reports 128 review notices for the new EMCN resource definitions, with no consumer violations or coverage failures. No scanner code or review artifacts are in this PR.

Validation

One hundred one focused EMCN/app tests, EMCN and app type checks, Biome, and diff whitespace checks passed on the reconciled head.
Twelve matched source-derived captures and computed-style comparisons cover light/dark, 16px/20px root text, and default/hover/focus. The recorded before/after values match. Evidence is outside the product checkout.
Independent source review checked the CVA recipe, barrel exports, Next navigation, accessibility, and disabled behavior.
Greptile and Cubic were requested on the reconciled head. Do not merge automatically.

Visual comparison

The isolated fixture renders the actual base and PR head side by side. It uses product CSS and the stated UI state.

Light · 16px root text · default

Dark · 20px root text · keyboard focus

The existing visual captures predate the staging reconciliation. The conflict resolution and current-head source examples are documented in the visual-review comment; no treatment values changed in that reconciliation.

BillLeoutsakosvl346 · 2026-09-24T18:45:39Z

@greptile review this PR

vercel · 2026-09-24T18:45:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 25, 2026 12:56am UTC

BillLeoutsakosvl346 · 2026-09-24T18:45:40Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T18:45:46Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

greptile-apps · 2026-09-24T18:49:32Z

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed changes.

Summary

The PR moves shared resource-row and tile rendering into EMCN while retaining the app’s Next Link adapter.

Re-exports the shared components and styling constants for existing consumers.
Updates affected test mocks and adds row and navigation tests.
The only change since the previous review fixes the test import; no new issue was identified.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[SettingsResourceRow] --> B[EMCN ResourceRow]
  A --> C[Next Link]
  B --> D[EMCN resource tile styling]

_{Reviews (4) · Last reviewed commit: "test(resources): use absolute row import"}

cubic-dev-ai

No issues found across 11 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai

No issues found across 11 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T18:57:14Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T18:57:16Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T18:57:20Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 12 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-25T00:00:46Z

Visual review: resource row and tile ownership

Change. The settings resource row and square identity tile move into EMCN. SettingsResourceRow remains a thin app adapter so a row with href still uses Next Link; action rows still use a button, and static/disabled rows keep their geometry. The same tile classes are now exported by EMCN for other resource surfaces.

Representative source excerpts:

Before

const rowClass = cn(
  'flex items-center justify-between gap-2.5',
  !flush && '-mx-2 rounded-lg p-2',
  disabled && 'opacity-50'
)

After

export function SettingsResourceRow(props: SettingsResourceRowProps) {
  if (props.href && !props.disabled) {
    const href = props.href
    return (
      <ResourceRow
        {...props}
        renderLink={(linkProps: ComponentProps<'a'>) => <Link {...linkProps} href={href} />}
      />
    )
  }

  return <ResourceRow {...props} />
}

Images. These are isolated renders of the actual base and head React components, using compiled product CSS and Season Sans. Each image has Before on the left and After on the right; Next Link is represented by a native anchor inside this fixture. Rows shown: linked, long-text with trailing action, disabled, and flush heading. The follow-up test commit and staging merge leave the resource component implementation unchanged.

Theme and root size	Before / After
Light, 16px
Dark, 16px
Light, 20px
Dark, 20px

Staging conflict resolution · `63c02c2a9e`

The only conflict was the EMCN export list. The merged head keeps staging's RowActions export alongside this PR's ResourceRow and ResourceTile exports:

export { ResourceRow, resourceRowIconVariants } from './resource-row/resource-row'
export { ResourceTile } from './resource-tile/resource-tile'
export { RowActions, rowActionsGroupClass } from './row-actions/row-actions'

This changes no rendered resource row or tile; the images above still cover that migration. Focused tests (101), EMCN/app type checks, and Biome pass. The local design diff check reports the new EMCN definitions for review, with no consumer violations or coverage failures.

Review follow-up · b744f87169: The latest commit changes a test import to the required absolute app path. It changes no product component, CSS, or visual state shown above.

BillLeoutsakosvl346 · 2026-09-25T00:44:23Z

@greptileai review this PR

BillLeoutsakosvl346 · 2026-09-25T00:44:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T00:44:33Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 12 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-25T00:56:27Z

@greptileai review this PR

BillLeoutsakosvl346 · 2026-09-25T00:56:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T00:56:33Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 12 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

refactor(emcn): own shared resource row and tile chrome

8e5451a

vercel Bot deployed to Preview September 24, 2026 18:48 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

test: include resource row in connector EMCN mock

9ea19d7

vercel Bot temporarily deployed to Preview September 24, 2026 18:57 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Merge staging into shared resource chrome

63c02c2

vercel Bot deployed to Preview September 25, 2026 00:34 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/settings/components/settings-resource-row/settings-resource-row.test.tsx Outdated

test(resources): use absolute row import

b744f87

vercel Bot temporarily deployed to Preview September 25, 2026 00:56 Inactive

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Base and design review

Validation

Visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual review: resource row and tile ownership

Staging conflict resolution · 63c02c2a9e

Uh oh!

BillLeoutsakosvl346 commented Sep 25, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 25, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

BillLeoutsakosvl346 commented Sep 25, 2026 •

edited

Loading

Staging conflict resolution · `63c02c2a9e`