Skip to content

improvement(chat): unify message styling and source previews - #8241

Merged
waleedlatif1 merged 4 commits into
stagingfrom
codex/chat-presentation-consistency
Sep 24, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
codex/chat-presentation-consistency

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use main’s Inter typography consistently across organization, workspace and workflow chat, including composers and source previews. Share inline references, file tags, choice controls and activity spacing.
  • Use existing tokens for inline code and links, center favicons, and preserve mixed formatting in nested lists. Keep full table cells in native horizontal scrollers with the canonical edge fade.
  • Add one source preview for links and citations with intent-loaded, cached public metadata and bounded Open Graph thumbnails. Private connector sources retain their supplied metadata. Limit thumbnail concurrency, retry transient image failures on later intent, and propagate cancellation through guarded DNS validation.

Type of Change

  • Improvement

Testing

The broad regression pass covered 3,121 passing tests. The latest changes passed 2,922 chat, composer, editor, preview, stream and security tests; one existing parser stress test timed out under parallel load and passed on an isolated rerun. Type-check and lint-check passed across all workspaces; all 49 audits, block registry, generated artifacts and docs manifest checks passed. Compared production components with main in light/dark themes and narrow layouts, including table edge fades, keyboard scrolling, mixed formatting and source previews. Completed the cleanup/design review.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 7:49pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no new actionable issue or outstanding previous finding was established.

Summary

The PR unifies chat typography, controls, table scrolling, and source previews. It also adds intent-loaded public metadata and bounded thumbnails, with cache freshness and guarded-fetch cancellation handling.

  • Rechecked all six previous Greptile threads; each is manually resolved and none is outstanding.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Link[Chat link or citation] --> Intent[Hover or focus]
  Intent --> Query[Preview query]
  Query --> Cache[Shared URL cache]
  Cache -->|miss| Route[Authenticated preview route]
  Route --> Guard[HTTPS and egress validation]
  Guard --> Page[Bounded page metadata]
  Page --> Image[Optional bounded thumbnail]
  Image --> Cache
  Cache --> Preview[Source preview]
Loading

Reviews (4) · Last reviewed commit: "fix(chat): restore Inter and refine tabl..."

Comment thread apps/sim/app/workspace/[workspaceId]/home/layout.tsx
Comment thread apps/sim/lib/link-preview/fetch-preview.ts
Comment thread apps/sim/lib/link-preview/fetch-preview.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 30 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/link-preview/fetch-preview.ts
Comment thread apps/sim/lib/link-preview/fetch-preview.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 39 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/link-preview/fetch-preview.ts Outdated
Comment thread apps/sim/lib/link-preview/fetch-preview.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 43 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/link-preview/fetch-preview.ts Outdated
Comment thread apps/sim/lib/link-preview/fetch-preview.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 51 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2671951 into staging Sep 24, 2026
37 of 38 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/chat-presentation-consistency branch September 24, 2026 19:57

This branch was previously deployed

1 inactive deployment
Preview — f021795d Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant