Share table sidebar shell and scroll body by BillLeoutsakosvl346 · Pull Request #8249 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T19:09:42Z

Summary

Share the identical sliding shell used by column, workflow, and enrichment table sidebars.
Share their identical scroll-body styling while leaving each form and footer in place.
Preserve the existing dialog labels, open/closed behavior, 400px width, scroll behavior, and shadow.

Base and verification

Base: #8065 (319f8bb2a9). This change and its focused regression test are on that head.

Focused table tests, including a new dialog/transition/scroll-state test, and final-head app TypeScript pass; changed-file Biome check passes.
12 before/after pairs cover light/dark, 16px/20px root text, and open/closed/scrolled states. The captures and computed geometry match.
The local design diff checker 3.10.7 reports zero findings or coverage failures against the exact PR base. The full base/head scanner comparison is being completed outside the product PR.

Screenshots and review artifacts are held outside the product checkout. No scanner code or rules are changed here.

vercel · 2026-09-24T19:09:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 7:15pm UTC

BillLeoutsakosvl346 · 2026-09-24T19:09:56Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:09:59Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:10:04Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

greptile-apps · 2026-09-24T19:13:14Z

Confidence Score: 5/5

The PR appears safe to merge; no outstanding finding or new actionable issue remains.

Summary

The PR extracts the common sliding shell and scroll-body styling used by the column, workflow, and enrichment table sidebars while retaining their individual forms and footers. A focused DOM test now covers the shared shell’s visibility transition and mounted content.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  C[Column sidebar] --> S[TableSidebarShell]
  W[Workflow sidebar] --> S
  E[Enrichments sidebar] --> S
  C --> B[TableSidebarScrollBody]
  W --> B
  EC[Enrichment configuration] --> B

_{Reviews (2) · Last reviewed commit: "test(tables): preserve sidebar scroll st..."}

BillLeoutsakosvl346 · 2026-09-24T19:15:33Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:15:37Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:15:43Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* improvement(emcn): share ordinary action geometry in Button * improvement(ui): share additional-field disclosures * fix(ui): preserve tiny actions and use shared sidebar geometry * improvement(ui): use shared geometry for standard icon actions (#8153) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): centralize overlay action buttons in EMCN (#7990) * refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): reuse shared button and focus treatments (#8187) * improvement(ui): reuse shared button and focus treatments * fix(emcn): include outline reset in muted focus ring * fix(ui): make closed table sidebars inert and strengthen focus ring * Carry code search overlay into the live EMCN stack (#8275) * refactor(ui): share code search overlay controls * refactor(emcn): own compact code search field chrome * test(ui): cover floating compact code search * refactor(emcn): compose compact search from shared chip surface --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): announce code search result changes * docs(ui): describe shared table sidebar exports --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

Share table sidebar shell and scroll body

27a7ab9

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-sidebar-layout.tsx

test(tables): cover shared sidebar dialog state

8ab92b1

vercel Bot temporarily deployed to Preview September 24, 2026 19:14 Inactive

test(tables): preserve sidebar scroll state

eed1bba

vercel Bot temporarily deployed to Preview September 24, 2026 19:15 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 5ca5a29 into codex/control-fix-workflow-preview-actions Sep 24, 2026
5 checks passed

waleedlatif1 deleted the codex/emcn-next-table-sidebar branch September 24, 2026 23:57

Navigation Menu

Share table sidebar shell and scroll body - #8249

Share table sidebar shell and scroll body#8249
BillLeoutsakosvl346 merged 3 commits into
codex/control-fix-workflow-preview-actionsfrom
codex/emcn-next-table-sidebar

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Base and verification

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading