-
Notifications
You must be signed in to change notification settings - Fork 3.8k
refactor(emcn): own shared shimmer text treatment #8252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BillLeoutsakosvl346
wants to merge
5
commits into
staging
Choose a base branch
from
codex/emcn-next-shimmer-text
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7108d6e
refactor(emcn): own shared shimmer text treatment
8d9f48c
test(emcn): assert shimmer class wiring
0975553
test(chat): preserve EMCN exports in message mock
cbbb28d
Merge staging into shared shimmer treatment
de0a95e
test(chat): mock EMCN exports explicitly
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...sim/components/ui/shimmer-text.module.css → ...ents/shimmer-text/shimmer-text.module.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/emcn/src/components/shimmer-text/shimmer-text.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { renderToStaticMarkup } from 'react-dom/server' | ||
| import { describe, expect, it } from 'vitest' | ||
| import { ShimmerText } from './shimmer-text' | ||
| import styles from './shimmer-text.module.css' | ||
|
|
||
| describe('ShimmerText', () => { | ||
| it('preserves the requested element, consumer classes, and native attributes', () => { | ||
| const html = renderToStaticMarkup( | ||
| <ShimmerText as='div' className='text-sm' data-testid='streaming-body'> | ||
| Writing a reply | ||
| </ShimmerText> | ||
| ) | ||
| expect(html).toMatch(/^<div /) | ||
| expect(html).toContain(styles.shimmer) | ||
| expect(html).toContain('text-sm') | ||
| expect(html).toContain('data-testid="streaming-body"') | ||
| expect(html).toContain('Writing a reply</div>') | ||
| }) | ||
| }) | ||
30 changes: 30 additions & 0 deletions
30
packages/emcn/src/components/shimmer-text/shimmer-text.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import type { ComponentPropsWithoutRef, ElementType, ReactNode } from 'react' | ||
| import { cn } from '../../lib/cn' | ||
| import styles from './shimmer-text.module.css' | ||
|
|
||
| export type ShimmerTextProps<T extends ElementType = 'span'> = { | ||
| as?: T | ||
| children: ReactNode | ||
| className?: string | ||
| } & Omit<ComponentPropsWithoutRef<T>, 'as' | 'children' | 'className'> | ||
|
|
||
| /** | ||
| * Sweeping-highlight shimmer for active text. Size and weight come from the | ||
| * consumer; `--shimmer-rest` supplies resting ink under reduced motion. | ||
| * | ||
| * @example | ||
| * <ShimmerText className='text-sm'>Working…</ShimmerText> | ||
| */ | ||
| export function ShimmerText<T extends ElementType = 'span'>({ | ||
| as, | ||
| children, | ||
| className, | ||
| ...props | ||
| }: ShimmerTextProps<T>) { | ||
| const Comp = as ?? 'span' | ||
| return ( | ||
| <Comp className={cn(styles.shimmer, className)} {...props}> | ||
| {children} | ||
| </Comp> | ||
| ) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.