Keep workflow preview values readable by BillLeoutsakosvl346 · Pull Request #8256 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T19:22:22Z

Summary

Keep workflow preview values readable while preserving their disabled interaction state. Scope full-opacity styling to explicit preview value sections and overlays, so ordinary disabled controls retain their disabled appearance. Correct the selected version row’s color-mix() input to use the HSL accent token properly.

Validation

Base: improvement(ui): share workflow preview actions #8065 at 319f8bb2a9d65d7237d5d67ea400b9164de33f48.
Focused tests: 75 existing tests and a new real SubBlock DOM test pass. The DOM test verifies the preview switch remains disabled after click and Space, has full opacity, and a normal disabled switch remains dim.
App type check and Biome pass. Local design diff checker 3.10.7 reports zero new findings and no coverage failures against the exact PR base. Its three advisories describe the scoped runtime stylesheet and the existing 10%/15% version-row accent treatment whose HSL syntax is corrected here.
Matched source-derived fixtures: light/dark at 16px and 20px root text, with normal, hover, and keyboard focus states. The four representative read-only value regions remain pixel-identical; ordinary disabled controls retain dimming. Evidence is stored outside this PR.
Full scanner base/head comparison is pending in the local integration review.

No scanner code or review artifacts are included in the product diff.

vercel · 2026-09-24T19:22:29Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 7:33pm UTC

BillLeoutsakosvl346 · 2026-09-24T19:22:40Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:22:47Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:22:51Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 19 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-24T19:28:24Z

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed changes.

Summary

The PR scopes full-opacity styling to marked read-only preview values while keeping preview controls disabled and ordinary disabled controls dim. It also corrects the selected version row’s HSL accent syntax. No changes were made since the previous review.

_{Reviews (3) · Last reviewed commit: "fix(ui): keep preview file actions inert"}

BillLeoutsakosvl346 · 2026-09-24T19:34:18Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:34:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:34:28Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 15 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T19:45:39Z

@greptile review this PR — the remaining type-only import is in unchanged parent #8065 code, outside this PR’s corrected base diff; I replied to and resolved that thread with the exact source provenance.

* improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* improvement(emcn): share ordinary action geometry in Button * improvement(ui): share additional-field disclosures * fix(ui): preserve tiny actions and use shared sidebar geometry * improvement(ui): use shared geometry for standard icon actions (#8153) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): centralize overlay action buttons in EMCN (#7990) * refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): reuse shared button and focus treatments (#8187) * improvement(ui): reuse shared button and focus treatments * fix(emcn): include outline reset in muted focus ring * fix(ui): make closed table sidebars inert and strengthen focus ring * Carry code search overlay into the live EMCN stack (#8275) * refactor(ui): share code search overlay controls * refactor(emcn): own compact code search field chrome * test(ui): cover floating compact code search * refactor(emcn): compose compact search from shared chip surface --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): announce code search result changes * docs(ui): describe shared table sidebar exports --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

fix(ui): keep preview values readable and restore version tint

5a5dfdd

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...pace/[workspaceId]/w/components/preview/components/preview-editor/preview-readonly-styles.ts

Comment thread ...el/components/editor/components/sub-block/components/selector-combobox/selector-combobox.tsx Outdated

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...mponents/panel/components/editor/components/sub-block/components/file-upload/file-upload.tsx

Comment thread apps/sim/components/workflow/workflow-preview-action.tsx

fix(ui): keep preview file actions inert

6674af0

BillLeoutsakosvl346 changed the base branch from codex/control-fix-overlay-action-buttons to codex/control-fix-workflow-preview-actions September 24, 2026 19:33

vercel Bot temporarily deployed to Preview September 24, 2026 19:33 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit c108046 into codex/control-fix-workflow-preview-actions Sep 24, 2026
5 checks passed

waleedlatif1 deleted the codex/emcn-next-preview-readonly branch September 24, 2026 23:57

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026

Summary

Validation

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Sep 24, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading