refactor(resources): share filter panel structure

[BillLeoutsakosvl346]

Summary

Share the exact resource-filter panel and field-section structure across Files, Tables, and document chunks. ResourceOptions continues to own the trigger and popover. The document status label retains its distinct typography; each page keeps its filter state, combobox props, and clear action.

Validation

• Comparison base: staging at d9db35e0a9376de1562abb1979826b522611a51a.
• Focused resource-options.test.tsx: 4 passed, including popover open, section focus, and clear action.
• Biome check and git diff --check: passed.
• Design diff checker 3.10.7 against the pinned staging base: 0 findings, 0 review items, and 0 coverage failures.
• App tsc --noEmit: passed with this worktree's own @sim/* workspace package links.
• Source-derived isolated fixtures with actual EMCN controls: all three panels have matching computed geometry and pixel-identical before/after captures in light and dark, at 16px and 20px root size, in normal and keyboard-focused states. The first combobox receives keyboard focus in the focused captures. Evidence is stored outside the product checkout at ~/.local/state/sim2/design-reviews/resource-filters-20260924/.
• The aggregate full scan runs on the separate local integration branch.

[BillLeoutsakosvl346]

@greptile

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 7:40pm UTC

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; no actionable regression was identified.

Summary

Extracts the existing filter-panel and section markup into shared components for Files, Tables, and document chunks. The document status label retains its distinct styling; filter state and actions remain page-owned.

_{Reviews (1) · Last reviewed commit: "refactor(resources): share filter panel ..."}

[cubic-dev-ai]

No issues found across 6 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[cubic-dev-ai]

No issues found across 6 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

Visual review: resource filter panels

What changed: Files, Tables, and document-chunk filters now share the existing 240px padded panel and stacked label/control structure. Each page keeps its filter choices, state, clear action, and the document status label’s distinct typography.

// Before — Files filter, opening of the File Type section
<div className='flex w-[240px] flex-col gap-3 p-3'>
  <div className='flex flex-col gap-1.5'>
    <span className={FILTER_SECTION_LABEL_CLASS}>File Type</span>

// After — the same section and unchanged ChipCombobox
<ResourceFilterPanel>
  <ResourceFilterSection label='File Type'>

What to inspect: Popover width, section spacing, label type, control placement, and keyboard focus. These are labeled isolated fixtures using source-exact panel/section classes, representative actual EMCN controls, and compiled product CSS; they are not authenticated Files or Tables route captures. The fixture compares staging d9db35e0a9 with current PR head 498718c975e2. All light/dark × 16px/20px × normal/focused screenshot pairs are byte-identical, and the focus control remains keyboard reachable. Four representative pairs:

Theme / root text / state	Before	After
Light / 16px / normal
Dark / 16px / focus
Light / 20px / focus
Dark / 20px / normal