fix(workspaces): persist visit recency server-side so sidebar order is stable on refresh by waleedlatif1 · Pull Request #8284 · simstudioai/sim

waleedlatif1 · 2026-09-25T00:55:45Z

Summary

Workspace visit order lived only in localStorage, so the server rendered the sidebar newest-first and the client re-sorted after hydration — non-pinned workspaces reshuffled on every refresh (pins were already server-side, so they stayed put)
New workspace_visit table (one row per user + workspace, last visit time); POST /api/workspaces/[id]/visit records a visit through a session-only workspaces.visits.record operation, replacing the settings write the sidebar made on every visit
Visits are stamped with the database clock and sent one at a time (mutation scope), so rapid switching always leaves the last-opened workspace newest
GET /api/workspaces returns workspaces most recently visited first (then newest first) and derives lastActiveWorkspaceId from the latest visit, falling back to the legacy settings column
Sidebar switcher and org sidebar read one order from the list query (pins lifted to the top in a select), so server render and hydration always agree and the order follows the user across devices
Visiting moves the workspace to the front of the cached list immediately; the list reconciles after the last queued visit settles
Removed WorkspaceRecencyStorage and useWorkspaceOrder
Anything taking workspaces[0] (the /workspace redirect fallback, orphaned-workflow repair) now gets the most recently visited workspace instead of the newest

Follow-up (after this is fully deployed): drop settings.last_active_workspace_id and its settings API fields, once the settings full-row inserts exclude it.

Type of Change

Bug fix

Testing

Hydration test asserts server render matches the final order and hydration changes zero DOM nodes
Unit tests for the visit use case (role, principal kinds, concealment, not found), route (401/200/404 parity), repository, ordering, and the visit mutation (optimistic reorder, serialization, last-settle reconcile)
lint, type-check, check:audits (49), check:api-validation:strict, check:migrations, docs-manifest:check pass

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

…s stable on refresh

vercel · 2026-09-25T00:55:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 25, 2026 1:16am UTC

cubic-dev-ai

All reported issues were addressed across 24 files

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-25T01:00:40Z

Confidence Score: 5/5

[High risk] Adds database migration and shifts workspace ordering to server-side.

The PR appears safe to merge based on the changes reviewed.

Summary

The PR persists workspace visit recency server-side and uses the resulting order for sidebars and workspace redirects.

Adds a visit endpoint, database table, and optimistic list update.
Replaces browser-only recency ordering and adds ordering and hydration tests.
The changes since the previous review address the remaining comment-format finding. All previous threads are resolved.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Open workspace] --> B[Record visit]
  B --> C[workspace_visit]
  C --> D[Workspace list in visit order]
  D --> E[Sidebar and redirects]

_{Reviews (5) · Last reviewed commit: "chore(workspaces): write the permission-..."}

waleedlatif1 · 2026-09-25T01:06:54Z

@greptile

waleedlatif1 · 2026-09-25T01:06:55Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T01:07:03Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 24 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

…e column for contract

waleedlatif1 · 2026-09-25T01:10:57Z

@greptile

waleedlatif1 · 2026-09-25T01:10:58Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T01:11:03Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-25T01:11:39Z

@greptile

waleedlatif1 · 2026-09-25T01:11:40Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T01:11:45Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 24 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

waleedlatif1 · 2026-09-25T01:16:52Z

@greptile

waleedlatif1 · 2026-09-25T01:16:53Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T01:16:58Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 24 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

fix(workspaces): persist visit recency server-side so sidebar order i…

69d3bba

…s stable on refresh

vercel Bot deployed to Preview September 25, 2026 00:57 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/lib/workspaces/visits.ts Outdated

Comment thread apps/sim/lib/workspaces/visits.ts Outdated

Comment thread packages/db/migrations/0383_workspace_visit.sql

Comment thread apps/sim/app/workspace/[workspaceId]/w/components/sidebar/hooks/use-workspace-management.ts Outdated

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/lib/workspaces/visits.ts Outdated

Comment thread apps/sim/hooks/queries/workspace.ts Outdated

Comment thread apps/sim/lib/workspaces/visits.ts Outdated

fix(workspaces): serialize visits and stamp them with the database clock

bf2c905

vercel Bot temporarily deployed to Preview September 25, 2026 01:06 Inactive

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

chore(workspaces): drop leftover churn and mark the legacy last-activ…

64a71eb

…e column for contract

chore(db): drop contract marker on settings.last_active_workspace_id

6a48a0d

vercel Bot deployed to Preview September 25, 2026 01:13 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/lib/workspaces/application/record-workspace-visit.ts Outdated

chore(workspaces): write the permission-group exemption as TSDoc

42fad40

vercel Bot temporarily deployed to Preview September 25, 2026 01:16 Inactive

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

waleedlatif1 merged commit 0be1f38 into staging Sep 25, 2026
34 checks passed

waleedlatif1 deleted the fix/sidebar-workspace-order-flash branch September 25, 2026 01:31

waleedlatif1 mentioned this pull request Sep 25, 2026

v0.9.0: mothership v1, live search, slack list and canvas tools, ui consolidation #8273

Merged

Conversation

waleedlatif1 commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 25, 2026 •

edited

Loading

vercel Bot commented Sep 25, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 25, 2026 •

edited

Loading