Skip to content

fix(api): prevent caching authenticated workflow variables #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 26, 2026
Merged

fix(api): prevent caching authenticated workflow variables #8339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions apps/sim/app/api/workflows/[id]/variables/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,18 +153,12 @@ export const GET = withRouteHandler(
}
}

// Add cache headers to prevent frequent reloading
const variableHash = JSON.stringify(variables).length
const headers = new Headers({
'Cache-Control': 'max-age=30, stale-while-revalidate=300', // Cache for 30 seconds, stale for 5 min
ETag: `"variables-${workflowId}-${variableHash}"`,
})

return NextResponse.json(
{ data: variables },
{
status: 200,
headers,
// Cookie-authenticated variables must not be stored or reused by HTTP caches.
headers: { 'Cache-Control': 'private, no-store' },
Comment thread
waleedlatif1 marked this conversation as resolved.
}
)
} catch (error) {
Expand Down
Loading