feat(search): expand live providers and discussion reads by waleedlatif1 · Pull Request #8340 · simstudioai/sim

waleedlatif1 · 2026-09-26T21:09:21Z

Summary

Add Linear, Fireflies, Granola and Notion to live Search using the existing account and authorization pipeline.
Include GitHub PR comments, reviews and inline discussions, plus Drive comments and replies, in document reads.
Share managed MCP read validation, make provider limits explicit in query guidance, bound streamed MCP events, and update the Granola icon.
Coordinate the matching worker contract and query guidance.

Companion: simstudioai/mothership#539

Type of Change

Feature enhancement

Testing

1,381 provider, authorization, legacy Search, MCP and integrations UI regression tests passed; nine real Postgres setup/rollback/concurrency tests passed.
Failure-first checks for argument validation, repeated cursors, oversized streamed events and structured transcript attribution.
Live Fireflies, Granola and Notion agent acceptance: 10 questions across 14 executions, with source facts and citations checked. Response latency: 8.172–18.776s, median 13.321s.
GitHub discussion and review acceptance against independent provider queries: seven positive cases plus five date-bound cases passed 30 checks. Real conversation and inline-comment matches are tied to their original comment IDs. Negative controls reject title-only or unrelated-comment evidence, absent review results, and contradictory approval expectations. Mixed queries verify separate issue and PR result limits. Approval expectations cover submitted review events; the adapter acceptance checks native inclusive date candidates, while application date filtering is covered separately. Linear OAuth was not included in live acceptance.
Type-check across 26 workspaces, lint, generated artifact checks, block-registry audit and all 51 audits passed.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-26T21:09:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 26, 2026 10:24pm UTC

github-actions · 2026-09-26T21:12:19Z

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

❌ simstudioai/mothership#539 — OPEN, not merged (targets staging) — feat(search): expand live provider contracts and query guidance

cubic-dev-ai

All reported issues were addressed across 57 files

_{Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

greptile-apps · 2026-09-26T21:14:24Z

Confidence Score: 5/5

[Medium risk] Adds new search providers and discussion-read features.

The PR appears safe to merge; no outstanding findings or accepted new issues remain.

Summary

The PR adds Linear, Fireflies, Granola, and Notion to live Search; expands GitHub and Drive discussion reads; and updates managed MCP setup, query guidance, transport limits, documentation, and acceptance checks. Subsequent changes bound Function and chat inputs, revise dependency scanning, and strengthen discussion-evidence checks.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Live Search request] --> B[Account and policy checks]
  B --> C{Provider}
  C --> D[Native provider API]
  C --> E[Managed MCP read adapter]
  D --> F[Search result or document read]
  E --> F
  F --> G[Source evidence and coverage status]

_{Reviews (5) · Last reviewed commit: "fix(search): bind acceptance evidence to..."}

waleedlatif1 · 2026-09-26T21:30:47Z

@greptile

waleedlatif1 · 2026-09-26T21:30:48Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T21:30:57Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 58 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-26T21:49:39Z

The latest Greptile summary includes grep scanning, workflow-variable caching, and Slack progress changes inherited from staging during rebase. They are not changes in this PR's current staging diff. GitHub's published file list and git diff origin/staging...HEAD agree: neither apps/sim/lib/mothership/agent-cli/engines/universal-grep.ts, apps/sim/lib/workflows/application/workflow-variables.ts, nor apps/sim/lib/slack-search/assistant-stream.ts is changed here; each file is byte-for-byte identical to staging.

The grep change came from staging PR #8338 (d9b9e1dc61), the workflow-variable change from #8339 (5b667d727f), and the Slack change from #8336 (7a36d74507). Please evaluate the search-provider PR against its current staging base rather than treating changes between its pre-rebase and post-rebase heads as newly introduced code. This clarification is about review scope; it does not dismiss a potential issue in the separate grep change.

waleedlatif1 · 2026-09-26T21:50:31Z

@greptile

waleedlatif1 · 2026-09-26T21:50:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T21:50:38Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 58 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/scripts/test-search-discussions-live.ts">

<violation number="1" location="apps/sim/scripts/test-search-discussions-live.ts:260">
P3: Untyped issue queries can return up to 10 issues plus 10 pull requests from the adapter, but the oracle fetches only 10 mixed results, so this check rejects valid results for mixed matches. Mirror the adapter’s type split in the oracle queries, or require an explicit `is:issue`/`is:pr` qualifier.</violation>
</file>

waleedlatif1 · 2026-09-26T22:04:32Z

@greptile

waleedlatif1 · 2026-09-26T22:04:33Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:04:39Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 58 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:23:08Z

@greptile

waleedlatif1 · 2026-09-26T22:23:09Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:23:15Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 58 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

vercel Bot deployed to Preview September 26, 2026 21:11 View deployment

github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Sep 26, 2026

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/lib/sim-search/live/linear.ts

waleedlatif1 force-pushed the codex/search-providers branch from 2a64d31 to ac85841 Compare September 26, 2026 21:29

vercel Bot deployed to Preview September 26, 2026 21:31 View deployment

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-search-discussions-live.ts Outdated

Comment thread apps/sim/scripts/test-search-discussions-live.ts Outdated

Comment thread apps/sim/scripts/test-search-discussions-live.ts Outdated

waleedlatif1 force-pushed the codex/search-providers branch from ac85841 to 755fec7 Compare September 26, 2026 21:49

vercel Bot deployed to Preview September 26, 2026 21:51 View deployment

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-search-discussions-live.ts

waleedlatif1 force-pushed the codex/search-providers branch from 755fec7 to e927bac Compare September 26, 2026 22:03

vercel Bot deployed to Preview September 26, 2026 22:05 View deployment

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-search-discussions-live.ts Outdated

waleedlatif1 added 4 commits September 26, 2026 15:17

feat(search): expand live providers and discussion reads

6cd8991

fix(search): preserve transcript details and account search

019e9b0

fix(search): require complete review and date evidence

e3456bc

fix(search): align mixed-query acceptance limits

363b835

fix(search): bind acceptance evidence to matched comments

5f39372

waleedlatif1 force-pushed the codex/search-providers branch from e927bac to 5f39372 Compare September 26, 2026 22:22

vercel Bot deployed to Preview September 26, 2026 22:24 View deployment

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-search-discussions-live.ts

waleedlatif1 merged commit 6a6a882 into staging Sep 26, 2026
33 checks passed

waleedlatif1 mentioned this pull request Sep 28, 2026

v0.9.4: db contention fixes, databricks genie, snowflake cortex, additional search connectors #8356

Merged

waleedlatif1 deleted the codex/search-providers branch September 28, 2026 19:56

Conversation

waleedlatif1 commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 26, 2026

⚠️ Cross-repo companion check

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

waleedlatif1 commented Sep 26, 2026 •

edited

Loading

vercel Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading