feat(databricks): add Genie agent operations to the Databricks block - #8343
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
1 issue found across 24 files
Confidence score: 4/5
- In
apps/sim/tools/databricks/genie_list_spaces.ts, parsing the response before checkingresponse.okcan hide an empty or non-JSON gateway failure behind a JSON parse error; checkresponse.okfirst and usereadDatabricksErrorto report the failure.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/tools/databricks/genie_list_spaces.ts">
<violation number="1" location="apps/sim/tools/databricks/genie_list_spaces.ts:57">
P2: This parses the response as JSON before checking `response.ok`, so an empty or non-JSON gateway error hides the actual failure behind a JSON parse exception. Check `response.ok` first and use `readDatabricksError` for failed responses, as the other Databricks mutation tools do.</violation>
</file>
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 24 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Fix all with cubic | Re-trigger cubic
Summary
conversationId. It polls until Genie reaches a terminal state and fetches the result rows. It returns the answer, clarifying question, SQL, query description, thoughts, suggested questions, visualizations and rows.TEXT_ATTACHMENT_PURPOSE_ANSWERtext is used as the answer; aFOLLOW_UP_QUESTIONtext is surfaced separately.agentType)/genie/agents/{id}/responsesand returns the final report, the SQL it ran, and every output item. List items pages through the conversation history.request.modelInput), because Genie sends it to an LLM.safeUrlPathSegment.Type of Change
Testing
bun run lint,type-check,check-block-registry,check:audits(51/51),docs-manifest:check, canvas sentences 26/26, and the blocks/tools vitest suites (131 passing).Checklist
test-auditauthoring gate)