improvement(knowledge): serve date tag filters from an index - #8348
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
No issues found across 10 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
Contributor
|
Collaborator
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
col::date <op> d::date, which no btree on the timestamp column can serve. Every date filter walked past its slot index, so improvement(db): drop unusable date slot and redundant prefix indexes #8332 dropped those never-used indexes. This makes date filtering index-backed insteadtimestampcolumn, e.g.eq d→col >= d AND col < d + 1 day. Each range selects exactly the rows the calendar-day comparison did: the slots have no time zone, and a NULL tag still matches nothingbuildDateTagCondition, is shared by search tag filters and the document list filter. Each keeps its existing fallback for unknown operators{emb,doc}_date1_idx/date2_idxconcurrentlyType of Change
Testing
between, under three session time zones, compared against the old::datepredicate evaluated on the same rows. Five boundary mutations of the builder each turn it redeq,between,gte, andltdate filters use the date index from both builders. It fails on the pre-change buildersembeddingin the vector leg's short-result rescue probe (55–61 ms → under 1 ms)check:audits, andcheck:migrations origin/stagingpassChecklist