fix(sim-setup): report Compose db/redis state in status - #8370
Merged
waleedlatif1 merged 2 commits intoSep 28, 2026
Merged
waleedlatif1 merged 2 commits into
waleedlatif1 merged 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
|
@AYANscyy2 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a Compose install,
sim-setup statusreports postgres and redis asabsentwhile both are healthy.statusonly readsdetectContainer, which matches the standalone namessim-postgres/sim-redis, but Compose names containers<project>-<service>-<n>.For each detected Compose install,
statusnow looks up thedbandredisservices by thecom.docker.compose.project+com.docker.compose.servicelabels (same approach asconfiguration-sources.ts). Standalone lines still print for dev installs.detectContaineris intentionally unchanged:dbContainer.managed/redisContainer.manageddrive start/stop of standalone containers indb.ts,redis.tsandlifecycle.ts, so matching Compose containers there would makestartrundocker start sim-redisagainst a Compose stack.Fixes #8353
Type of Change
Testing
bun run testin sim-setup passes;tsc --noEmitand Biome cleannpx sim-setup --quick --mode compose:Before (published sim-setup 1.0.30):
After (this branch):
After, with the db container stopped:
The second point in the issue (
stoprun from another directory) is a separate change; happy to follow up.Changes since first review
Both Greptile P2 findings are addressed in 5cc5659:
docker ps -anowreports
unknown; an empty result still meansabsent.Compose-vs-standalone row selection.
Checklist