Skip to content

fix(mcp): add directory verification compatibility - #8826

Closed
waleedlatif1 wants to merge 2 commits into
mainfrom
codex/directory-verification-production
Closed

waleedlatif1 wants to merge 2 commits into
mainfrom
codex/directory-verification-production

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Set explicit non-destructive annotations on the existing read-only MCP tools.
  • Serve the public directory ownership challenge on the dedicated MCP host for automated clients while keeping other app routes inaccessible there.
  • Verify the actual challenge body, headers, and host isolation over HTTP in CI.

Type of Change

  • Bug fix

Testing

MCP routing and automated-client regressions fail before the change and pass afterward; all 70 focused tests passed before the HTTP coverage addition. The HTTP suite writes a JSON report and runs in the existing CI E2E job. Final tests, builds, lint, type checks, and audits run in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 1:53am UTC

Request Review

@waleedlatif1
waleedlatif1 marked this pull request as ready for review October 9, 2026 01:34

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

This PR marks existing read-only MCP tools as non-destructive and serves the public ownership challenge on the dedicated MCP host.

  • Automated clients can fetch the exact challenge path without being blocked by the user-agent filter.
  • Other app routes remain blocked on the dedicated host.
  • The new HTTP suite checks the challenge body, headers, and host separation in CI.
  • No new actionable issues were found. Tests were not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[HTTP request] --> B{Dedicated MCP host?}
  B -->|No| C[Normal app routing]
  B -->|Yes| D{Allowed path?}
  D -->|MCP or resource metadata| E[Rewrite to internal route]
  D -->|Ownership challenge| F[Serve fixed plain-text challenge]
  D -->|Authorization metadata| G[Serve discovery metadata]
  D -->|Other path| H[Return 404]
Loading

Reviews (2) · Last reviewed commit: "test(mcp): verify ownership challenge ov..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/scripts/test-mcp-host-e2e.ts
@waleedlatif1
waleedlatif1 deleted the codex/directory-verification-production branch October 9, 2026 04:08

This branch was successfully deployed

1 active deployment
Preview — d9bbbc82 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant