fix(search): return actionable live read errors and drop unreadable Confluence matches by waleedlatif1 · Pull Request #8888 · simstudioai/sim

waleedlatif1 · 2026-10-10T05:15:01Z

Summary

read_document turned every provider-side read failure into the generic "Knowledge operation failed", because NativeSearchError escaped readLiveDocument without being classified. Reads now return errors the model can act on:
- a 404 or 410 becomes not_found, with a hint to search again or read a different result;
- a revoked grant becomes unauthorized, naming the provider to reconnect;
- rate limits, 5xx responses, provider timeouts, MCP request timeouts and the 15 s read deadline become a retryable LiveReadError.
The Assistant read_document tool now reports retryable (and retryAfterSeconds when set), the same way search_workspace does. The Search MCP read_document returns the classified message instead of the generic text.
Confluence search labeled every non-blogpost CQL hit a page. Native CQL that matched attachments, comments, whiteboards, folders or databases therefore produced references whose v2 page read returns 404. Those kinds are now dropped, and the result message says so.

Test plan

application.test.ts: covers 404, reconnect, rate limit, 503 and MCP timeout. All five fail with the fix reverted.
atlassian.test.ts: covers native CQL matches that a page read can't open. It fails with the fix reverted.
Focused suites pass locally: application, atlassian, policy, workspace-search, mcp server.
CI

🤖 Generated with Claude Code

vercel · 2026-10-10T05:15:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 10, 2026 9:25pm UTC

cubic-dev-ai

All reported issues were addressed across 7 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-10T05:19:28Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issue was found.

Summary

This PR gives callers clearer live document read errors and removes Confluence matches that the reader cannot open.

Live document reads tell callers what to do when a provider fails.
Confluence search returns only matches its reader can open.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Live document read fails] --> B{Caller cancelled?}
  B -->|Yes| C[Keep cancellation unchanged]
  B -->|No| D{Failure kind}
  D -->|Missing document| E[Search again or choose another result]
  D -->|Revoked grant| F[Reconnect provider]
  D -->|Temporary failure| G[Return retry guidance]
  D -->|Other failure| H[Keep existing error path]
  G --> I[Assistant receives retryable fields]
  G --> J[MCP receives actionable text]

_{Reviews (4) · Last reviewed commit: "fix(search): treat a provider 408 as a r..." · Reviewed by Greptile}

waleedlatif1 · 2026-10-10T20:47:16Z

@greptile

waleedlatif1 · 2026-10-10T20:47:17Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T20:47:23Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-10T21:06:41Z

@greptile

waleedlatif1 · 2026-10-10T21:06:42Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T21:06:48Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 8 files

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

…onfluence matches read_document collapsed every provider-side read failure into the generic 'Knowledge operation failed' because NativeSearchError escaped readLiveDocument unclassified. Reads now map a 404/410 to not_found with a search-again hint, a revoked grant to unauthorized naming the provider, and rate limits, 5xx, provider timeouts, MCP request timeouts and the read deadline to a retryable LiveReadError that the Assistant tool reports with retryable (and retryAfterSeconds) like search_workspace. Confluence search labeled every non-blogpost CQL hit a page, so native CQL matching attachments, comments, whiteboards, folders or databases produced references whose v2 page read 404s. Those kinds are now dropped and the page message says so.

…naged read

…luence matches partial

waleedlatif1 · 2026-10-10T21:25:55Z

@greptile

waleedlatif1 · 2026-10-10T21:25:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T21:26:02Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

vercel Bot temporarily deployed to Preview October 10, 2026 05:15 Inactive

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread apps/sim/lib/sim-search/live/application.ts

Comment thread apps/sim/lib/sim-search/live/atlassian.ts

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread apps/sim/lib/sim-search/live/application.ts

vercel Bot temporarily deployed to Preview October 10, 2026 07:11 Inactive

vercel Bot temporarily deployed to Preview October 10, 2026 10:19 Inactive

vercel Bot temporarily deployed to Preview October 10, 2026 20:45 Inactive

waleedlatif1 force-pushed the fix/live-read-errors branch from 91d030c to 34529ec Compare October 10, 2026 20:45

vercel Bot temporarily deployed to Preview October 10, 2026 20:45 Inactive

vercel Bot temporarily deployed to Preview October 10, 2026 20:46 Inactive

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

waleedlatif1 force-pushed the fix/live-read-errors branch from 3354301 to 7a2d89a Compare October 10, 2026 21:06

vercel Bot temporarily deployed to Preview October 10, 2026 21:09 Inactive

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread apps/sim/lib/sim-search/live/application.ts

waleedlatif1 added 6 commits October 10, 2026 14:25

test(search): drop a non-null assertion from the live read error test

bb7a5be

test(search): expect the classified reconnect error from a revoked ma…

587bb52

…naged read

refactor(search): flatten live read failure classification

1288c12

fix(search): retry native read socket timeouts and mark excluded Conf…

71767ed

…luence matches partial

fix(search): treat a provider 408 as a retryable read timeout

3c25750

waleedlatif1 force-pushed the fix/live-read-errors branch from 7a2d89a to 3c25750 Compare October 10, 2026 21:25

vercel Bot temporarily deployed to Preview October 10, 2026 21:25 Inactive

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

waleedlatif1 merged commit 558d96d into staging Oct 10, 2026
48 checks passed

waleedlatif1 deleted the fix/live-read-errors branch October 10, 2026 22:04

Conversation

waleedlatif1 commented Oct 10, 2026

Summary

Test plan

Uh oh!

vercel Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading