Skip to content

Is there a plan to make this project fully compatible with rugged? #2

Description

@zhuangbiaowei

e.g.

repo.last_commit.oid return -> String

but,in this lib:

repo.last_commit.target_id.to_s return -> String

Activity

  1. smacker commented on Feb 13, 2019

    @smacker
    Owner

    The aim is to be as compatible as possible but most probably it will be impossible to archive 100% compatibility.
    Please also keep in mind that the project is at a very early stage right now.

  2. zhuangbiaowei commented on Feb 14, 2019

    @zhuangbiaowei
    Author

    I am also working on this project recently. If you are interested, I hope to submit PR to you.

    https://github.com/zhuangbiaowei/libgit2.cr

  3. bew commented on Mar 7, 2019

    @bew

    @zhuangbiaowei Nice work!

    Since you did quite a lot of changes, I'd suggest to make multiple small PR for each kind of changes you did.
    This way the reviewer (@smacker) does have too much code to review and you get better feedback on it.

  4. zhuangbiaowei commented on Mar 13, 2019

    @zhuangbiaowei
    Author

    @bew Thank you for your suggestion.

    I am willing to submit some smaller PRs. However, I am more worried about @smacker. It seems that his time is not very certain. In my comments, he will take a long time to reply...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions