Guard capability duration metrics against invalid timestamps - #754
Open
Krish-vemula wants to merge 1 commit into
Open
Krish-vemula wants to merge 1 commit into
Krish-vemula wants to merge 1 commit into
Conversation
|
Krish-vemula
marked this pull request as ready for review
September 10, 2026 16:27
product-security-plaid-production
Bot
requested review from
DylanTinianov and
cedric-cordenier
and removed request for
cedric-cordenier
September 10, 2026 16:28
ilija42
reviewed
Sep 14, 2026
| Unit: "ms", | ||
| Description: fmt.Sprintf("The duration (local) since capability exec start to message: '%s' emit", eventRef), | ||
| }, | ||
| invalidTelemetry: beholder.MetricInfo{ |
Contributor
There was a problem hiding this comment.
when does this get emitted?
Contributor
Author
There was a problem hiding this comment.
From RecordEmit, only when the timestamp pair is invalid (emit < start or timestamp > MaxInt64). It marks samples we intentionally skip for timestamp/duration recording while still counting the event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordEmit