Helper to calculate average RequestTimeout - #769
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
agparadiso,
archseer and
dhaidashenko
September 16, 2026 09:03
Contributor
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
yashnevatia
changed the title
yashnevatia
changed the title
| // differ from regular executable methods. If the config can't be fetched or no | ||
| // eligible RemoteExecutableConfig.RequestTimeout values are found, it returns | ||
| // fallback. | ||
| func AverageRequestTimeout(ctx context.Context, registry core.CapabilitiesRegistry, capabilityID string, donID uint32, fallback time.Duration, lggr logger.Logger) time.Duration { |
Contributor
There was a problem hiding this comment.
Why not use max? If we use avg, there is a chance that an unknown request will expire before the timeout.
Contributor
Author
There was a problem hiding this comment.
that is a very fair point
|
dhaidashenko
approved these changes
Sep 21, 2026
yashnevatia
enabled auto-merge
September 21, 2026 11:47
Unheilbar
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new helper function for calculating the max request timeout for a capability.
New helper function
MAxRequestTimeouttohelpers.go, which computes the maxRequestTimeoutacross all eligible method configs for a given capability and DON, excludingWriteReportandLogTriggermethods. It uses a retry mechanism for fetching configs and falls back to a default value if necessary.