Add cache size for unknown requests in consensus handler - #770
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
agparadiso,
dhaidashenko and
pavel-raykov
September 16, 2026 09:09
pavel-raykov
previously approved these changes
Sep 16, 2026
| request := s.requests.Get(id) | ||
| if request == nil { | ||
| if s.maxUnknownRequestsCacheSize > 0 && len(s.unknownRequestsResultByID) >= s.maxUnknownRequestsCacheSize { | ||
| if oldest := s.unknownRequestsOrderedByTimeout.Front(); oldest != nil { |
Contributor
There was a problem hiding this comment.
It would be nice to have visibility into the size of the unknown requests cache.
I'm ok with logging on evictiond due to overflow or a metric
|
dhaidashenko
approved these changes
Sep 21, 2026
yashnevatia
enabled auto-merge
September 21, 2026 11:47
Unheilbar
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.