Skip to content

Bump common - #774

Merged
cedric-cordenier merged 9 commits into
mainfrom
bump-common
Sep 21, 2026
Merged

Bump common#774
cedric-cordenier merged 9 commits into
mainfrom
bump-common

Conversation

@cedric-cordenier

@cedric-cordenier cedric-cordenier commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Bump common across capabilities to the latest version which cleans up legacy Keystone code
  • Remove disabled tests in integration_tests
  • Re-enable the EVM integration tests which were incorrectly disabled; this involved migrating the framework code to using v2 contracts only.

@cedric-cordenier
cedric-cordenier requested review from a team as code owners September 17, 2026 12:34
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

dhaidashenko
dhaidashenko previously approved these changes Sep 17, 2026
View reviewed changes
@cedric-cordenier
cedric-cordenier force-pushed the bump-common branch 2 times, most recently from d3430bd to 0eaf904 Compare September 18, 2026 12:50
george-dorin
george-dorin previously approved these changes Sep 18, 2026
View reviewed changes
russell-stern
russell-stern previously approved these changes Sep 18, 2026
View reviewed changes
Comment thread cron/trigger/trigger.go Outdated
type Response struct {
capabilities.TriggerEvent
Payload cron.Payload
Payload Payload

@russell-stern russell-stern Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this Payload come from v2 cron instead of redefining it here?

@cedric-cordenier cedric-cordenier Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually is only used in tests to power the RegisterLegacy methods; I've moved Response to the test file -- we should ideally clean up the tests, but I want to avoid the scope creep here

@cl-sonarqube-production

cl-sonarqube-production Bot commented Sep 21, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier
cedric-cordenier added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 287e48c Sep 21, 2026
76 checks passed
@cedric-cordenier
cedric-cordenier deleted the bump-common branch September 21, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agparadiso agparadiso agparadiso approved these changes
@george-dorin george-dorin george-dorin approved these changes
@russell-stern russell-stern russell-stern left review comments
@silaslenihan silaslenihan Awaiting requested review from silaslenihan
@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cedric-cordenier @agparadiso @dhaidashenko @george-dorin @russell-stern