Repository navigation
Conversation
kuhe
marked this pull request as ready for review
October 19, 2026 19:43
stobrien89
requested changes
Oct 19, 2026
| writeMemberDocs(writer, member); | ||
| } | ||
| if (carriesResponseMetadata(shape)) { | ||
| writer.write("response_metadata: $T = ...", RuntimeTypes.RESPONSE_METADATA); |
Contributor
There was a problem hiding this comment.
Can we restore the response_metadata docs here too? This field had generated docs before lazy loading, and writeMemberDocs can’t cover it since it isn’t modeled
Contributor
There was a problem hiding this comment.
Same thing with ServiceError
Contributor
Author
There was a problem hiding this comment.
the response_metadata block is too repetitive, since it appears on all classes. The ResponseMetadata type will provide that information.
ServiceError can have a docblock, in commit 2.
stobrien89
approved these changes
Oct 19, 2026
jonathan343
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation comments for models.pyi.
No
__doc__for runtime though. That would require carrying a lot more text in memory.