Repository navigation
[GUI.Batch] Remove duplicated speed result - #6317
Merged
Merged
Conversation
fredroy
force-pushed
the
remove_dup_batch_res
branch
from
September 23, 2026 09:11
50f49b8 to
61ce6e9
Compare
alxbilger
approved these changes
Oct 1, 2026
fredroy
force-pushed
the
remove_dup_batch_res
branch
from
October 6, 2026 01:39
61ce6e9 to
baa02e9
Compare
hugtalbot
approved these changes
Oct 6, 2026
alxbilger
force-pushed
the
remove_dup_batch_res
branch
from
October 7, 2026 18:31
249dd2a to
1ac58e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running batch mode was always displaying the (same) result twice at the end (and bothersome to grep everytime 😶🌫️)
This PR itself just removes one line (one using getFastTime() )
For a future PR maybe.
After investigation (and some explanation from Mister C.) , it seems it was supposed to trace with different time measurement. In a nutshell, it depends if SOFA_RDTSC is defined. If defined getFastTime() will use a CPU instruction (
rdtsc) instead of syscall, which involves overhead apparently.The problem is:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if