Skip to content

[GUI.Batch] Remove duplicated speed result - #6317

Merged
alxbilger merged 1 commit into
sofa-framework:masterfrom
fredroy:remove_dup_batch_res
Oct 7, 2026
Merged

alxbilger merged 1 commit into
sofa-framework:masterfrom
fredroy:remove_dup_batch_res

Conversation

@fredroy

@fredroy fredroy commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Running batch mode was always displaying the (same) result twice at the end (and bothersome to grep everytime 😶‍🌫️)

This PR itself just removes one line (one using getFastTime() )


For a future PR maybe.

After investigation (and some explanation from Mister C.) , it seems it was supposed to trace with different time measurement. In a nutshell, it depends if SOFA_RDTSC is defined. If defined getFastTime() will use a CPU instruction (rdtsc) instead of syscall, which involves overhead apparently.

The problem is:

  • nowhere SOFA_RDTSC can be enabled (no CMake option) so you have to add manually the define in CXX_FLAGS. otherwise getFastTime = getRefTime() )
  • it needs to be used with computeTicksPerSec() which is not reliable with today's CPU (changes with cpu frequency, turboboost, etc) and multi-CPU (multicore, bigLITTLE, etc)
  • and arm does not support it anyway

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Sep 23, 2026
@fredroy
fredroy force-pushed the remove_dup_batch_res branch from 50f49b8 to 61ce6e9 Compare September 23, 2026 09:11
@fredroy
fredroy force-pushed the remove_dup_batch_res branch from 61ce6e9 to baa02e9 Compare October 6, 2026 01:39
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 6, 2026
@alxbilger
alxbilger force-pushed the remove_dup_batch_res branch from 249dd2a to 1ac58e0 Compare October 7, 2026 18:31
@alxbilger
alxbilger merged commit c43709e into sofa-framework:master Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants