Skip to content

[all] Rename applyJ to applyJacobianVectorProduct - #6358

Open
alxbilger wants to merge 31 commits into
sofa-framework:masterfrom
alxbilger:jvp
Open

alxbilger wants to merge 31 commits into
sofa-framework:masterfrom
alxbilger:jvp

Conversation

@alxbilger

@alxbilger alxbilger commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
  • Clearer name
  • Add a new parameter to the method: $x$, because $J=J(x)$
  • Apply template method pattern with the do prefix: doApplyJacobianVectorProduct. To better differentiate both methods.

[with-all-tests]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/641]
[ci-depends-on https://github.com/SofaDefrost/Cosserat/pull/190]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: refactoring Refactor code labels Oct 7, 2026
@alxbilger alxbilger added the pr: breaking Change possibly inducing a compilation error label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: refactoring Refactor code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant