Skip to content

Keep the pointerEvents ts-expect-error in emitted spec declarations #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 1 commit into from
Oct 16, 2026
Merged

Keep the pointerEvents ts-expect-error in emitted spec declarations #4601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/specs/RNGestureHandlerButtonNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export type ButtonEvent = Readonly<{
pointerType: CodegenTypes.Int32;
}>;

// @ts-ignore - Redefining pointerEvents with WithDefault for codegen, conflicts with ViewProps type but codegen needs it
/** @ts-ignore - Redefining pointerEvents with WithDefault for codegen, conflicts with ViewProps type but codegen needs it */
interface NativeProps extends ViewProps {
// The events are namespaced with `Button` because the base view config on iOS
// already registers `topPress` as a bubbling event — a direct event with the
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/specs/RNGestureHandlerDetectorNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export interface VirtualChildrenProps {
viewTag: CodegenTypes.Int32;
}

// @ts-expect-error WithDefault adds `| null` to the type, which doesn't align with ViewProps.pointerEvents
/** @ts-expect-error WithDefault adds `| null` to the type, which doesn't align with ViewProps.pointerEvents */
// Using Exclude to remove null from the type makes the error go away, but breaks codegen.
Comment thread
m-bert marked this conversation as resolved.
export interface NativeProps extends ViewProps {
onGestureHandlerEvent?:
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/specs/RNGestureHandlerRootViewNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export interface RootViewNativeProps extends ViewProps {
unstable_forceActive?: boolean;
}

// @ts-expect-error WithDefault adds null for codegen, unlike ViewProps.pointerEvents.
/** @ts-expect-error WithDefault adds null for codegen, unlike ViewProps.pointerEvents. */
interface NativeProps extends ViewProps {
pointerEvents?: CodegenTypes.WithDefault<
'box-none' | 'none' | 'box-only' | 'auto',
Expand Down
Loading