fix: allow @testing-library/jest-dom v7 on the next line - #358
Merged
Conversation
Ports #287 from main. The Solid 2.0 templates pin jest-dom ^7.0.0 and npm enforces peer ranges, so a clean npm install of a freshly created project failed with ERESOLVE against the ^6.* range (solidjs/solid#3341). v7 keeps the @testing-library/jest-dom/vitest subpath the plugin auto-injects, so only the peer range changes. Co-authored-by: Claude via Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: ed9b798 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #287 (merged to
mainas 2.11.14) to thenextline.Problem
@solidjs/vite-plugin@3.0.0-next.41declarespeerOptional @testing-library/jest-dom: "^5.16.6 || ^5.17.0 || ^6.*". The Solid 2.0 templates moved to@testing-library/jest-dom@^7.0.0(solidjs/templates#302), and npm 7+ hard-fails on peer conflicts, so a cleannpm installof a project freshly created bynpm init solid@latesterrors withERESOLVE. pnpm only warns, which is why the templates repo itself installs fine.Fixes solidjs/solid#3341.
Fix
Widen the optional peer range to
^5.16.6 || ^5.17.0 || ^6.0.0 || ^7.0.0, same as #287. No code change: v7 keeps the@testing-library/jest-dom/vitestsubpath thatgetJestDomExportauto-injects intotest.setupFiles. The lockfile diff is the one-line specifier update.Verification
Reproduced the
ERESOLVEwith the published next.41 on a freshwith-tailwindcsscopy under npm 11, then swapped in a tarball built from this branch:npm installsucceeds (jest-dom 7.0.1 resolved) and the template'svitest runpasses with the plugin-injected jest-dom setup.Authored by Claude via Cursor.
Made with Cursor