Skip to content

chore(h): fix JSX runtime clean path - #3344

Merged
ryansolid merged 2 commits into
solidjs:nextfrom
nickshiro:chore/fix-h-jsx-runtime-clean-path
Sep 10, 2026
Merged

chore(h): fix JSX runtime clean path#3344
ryansolid merged 2 commits into
solidjs:nextfrom
nickshiro:chore/fix-h-jsx-runtime-clean-path

Conversation

@nickshiro

Copy link
Copy Markdown

Summary

Fix the @solidjs/h clean script so it removes the package-local JSX runtime output. The previous /jsx-runtime/dist argument was an absolute path. As a result, rimraf looked for the directory at the filesystem root instead of cleaning packages/h/jsx-runtime/dist/. This could allow stale JSX runtime bundles, such as old CommonJS artifacts, to survive subsequent builds.

How did you test this change?

  • Added a temporary stale artifact to packages/h/jsx-runtime/dist/.
  • Ran pnpm --filter @solidjs/h run build.
  • Verified that the stale artifact and old jsx.cjs output were removed.
  • Verified that the current jsx.js bundle was regenerated.

@changeset-bot

changeset-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 08a1546

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq

codspeed-hq Bot commented Sep 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 151 untouched benchmarks


Comparing nickshiro:chore/fix-h-jsx-runtime-clean-path (08a1546) with next (7f416cf)

Open in CodSpeed

@ryansolid
ryansolid merged commit 005a623 into solidjs:next Sep 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants