chore(h): fix JSX runtime clean path - #3344
Merged
ryansolid merged 2 commits intoSep 10, 2026
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
@solidjs/hclean script so it removes the package-local JSX runtime output. The previous/jsx-runtime/distargument was an absolute path. As a result,rimraflooked for the directory at the filesystem root instead of cleaningpackages/h/jsx-runtime/dist/. This could allow stale JSX runtime bundles, such as old CommonJS artifacts, to survive subsequent builds.How did you test this change?
packages/h/jsx-runtime/dist/.pnpm --filter @solidjs/h run build.jsx.cjsoutput were removed.jsx.jsbundle was regenerated.