Repository navigation
fix: restore yarn.lock resolutions reverted by #947's merge - #987
Merged
Merged
Conversation
#947's merge resolved a yarn.lock conflict by regenerating the whole file via a plain `yarn install`, which re-resolved every package from scratch - at that moment, many packages' true-latest versions were too recently published to pass .yarnrc.yml's npmMinimalAgeGate (3 days), so yarn silently fell back to older versions across roughly 115 unrelated packages (e.g. @cspell/* dropped from 10.3.3 back to 10.1.1), reintroducing already-fixed security advisories alongside the actual robot_simulation changes. Restores yarn.lock from the commit right before #947 merged, then re-adds only the handful of entries robot_simulation's own package.json changes actually need (three/@types/three bump, the real @sourceacademy/py-slang npm dependency, @sourceacademy/modules-testplugin). Diffed against the pre-#947 lockfile to confirm: one resolution changed (@sourceacademy/conductor, forward within its existing catalog range - not a revert), zero others. Verified: tsc, build, and all 131 robot_simulation tests still pass.
martin-henz
approved these changes
Oct 7, 2026
martin-henz
left a comment
martin-henz
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this @Akshay-2007-1 and @RichDom2185 for pointing out the issue. Due to the security implications, I'm approving and merging right away.
martin-henz
self-requested a review
October 7, 2026 00:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
Per @RichDom2185's review on #947: that PR's merge resolved a yarn.lock conflict by regenerating the whole file via a plain
yarn install. That re-resolved every package in the workspace from scratch, not just the ones robot_simulation actually changed. At that moment, many packages' true-latest versions were too recently published to pass.yarnrc.yml'snpmMinimalAgeGate(3 days), so yarn silently fell back to older already-aged versions across the board - about 115 unrelated resolutions reverted (e.g.@cspell/*dropped from10.3.3back to10.1.1), reintroducing security advisories that had already been fixed onmaster.Fix
yarn.lockfrom the commit immediately before robot_simulation: let a control program be written in Python #947 merged (the last known-good state).package.jsonchanges actually need: thethree/@types/threebump, the real@sourceacademy/py-slangnpm dependency (replacing a localportal:path), and@sourceacademy/modules-testplugin.@sourceacademy/conductor, moving forward within its existing catalog range, not a revert) - zero others.Testing
tsc,build, and all 131robot_simulationtests pass with the restored lockfile.