Repository navigation
chore/ci: Add DiffTour link to PRs - #486
Merged
BolajiOlajide merged 2 commits intoSep 24, 2026
Merged
BolajiOlajide merged 2 commits into
BolajiOlajide merged 2 commits into
Conversation
Adding the shared sourcegraph/actions/diff-tour action to comment on PRs with the Diff Tour link. Please make any needed improvements to the shared action, so all of our repos using it benefit. Co-authored-by: marcleblanc2 <marcleblanc2@users.noreply.github.com>
marcleblanc2
enabled auto-merge (squash)
September 23, 2026 01:22
marcleblanc2
added a commit
that referenced
this pull request
Sep 23, 2026
## Why The SCIP workflow pinned `actions/checkout@50fbc622fc4ef5163becd7fab6573eac35f8462e`, which is **v1 from November 2019** (the old runner-plugin implementation). Its `fetch-depth` defaults to *no limit*, so every push fetched every branch and tag (~17.5k objects), and it fetches `refs/heads/*` rather than the commit under test. That caused [this failure](https://github.com/sourcegraph/deploy-sourcegraph-k8s/actions/runs/35804998910/job/107003696130) on #486: the branch was force-pushed one second after the first push, the fetch picked up the new tip only, and checkout of the original commit died with `fatal: unable to read tree`. ## What Bump to `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1`, the current release. - Defaults to `fetch-depth: 1`, so the job clones shallow. - Fetches the exact `github.sha`, which GitHub still serves after a force-push, so the race goes away. `scip-go` and `src code-intel upload` only need the working tree and `git rev-parse HEAD`; neither needs history. ## Test plan The SCIP workflow runs on push to this branch; confirm the checkout step logs `--depth=1` and the job passes. Co-authored-by: Amp <amp@ampcode.com>
valerybugakov
approved these changes
Sep 24, 2026
BolajiOlajide
disabled auto-merge
September 24, 2026 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the shared sourcegraph/actions/diff-tour action to comment on PRs with the Diff Tour link. Please make any needed improvements to the shared action, so all of our repos using it benefit.
Created by a Sourcegraph agentic batch change.