Create a pseudo valid email when user not found - #11
Open
daxmc99 wants to merge 7 commits into
Open
Conversation
asdine
force-pushed
the
improved-concurrency
branch
from
September 8, 2021 14:03
c29a378 to
819afdd
Compare
|
I think we should let the user choose the strategy:
|
Allow user to set a manual override but fail by default now
daxmc99
force-pushed
the
commiter-email
branch
from
September 10, 2021 00:05
3587113 to
3a2d90b
Compare
Author
|
Example output from this |
daxmc99
commented
Sep 10, 2021
| except IndexError: | ||
| return f"{userid} {userid}@{userid}.invalid>" | ||
| else: | ||
| signal.raise_signal(signal.SIGINT) # needed to stop all threads |
Author
There was a problem hiding this comment.
Noticed this is needed to prevent us from hanging when we exit
Author
|
@asdine This should be ready for review now, let me know what you think |
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
keegancsmith
pushed a commit
that referenced
this pull request
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the issue was that the email addresses were not syntactically valid. This creates emails with the
.invalidTLD.