Resolve schema collection references by file, as the JSON Schema CLI does by jviotti · Pull Request #1294 · sourcemeta/one

jviotti · 2026-09-29T19:32:41Z

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

…does Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

github-actions

Benchmark (community)

Details

Benchmark suite	Current: `8dc48ab`	Previous: `e85241d`	Ratio
`Add one schema (0 existing)`	`237` ms	`189` ms	`1.25`
`Add one schema (100 existing)`	`45` ms	`33` ms	`1.36`
`Add one schema (1000 existing)`	`98` ms	`155` ms	`0.63`
`Add one schema (10000 existing)`	`788` ms	`860` ms	`0.92`
`Update one schema (1 existing)`	`31` ms	`29` ms	`1.07`
`Update one schema (101 existing)`	`41` ms	`35` ms	`1.17`
`Update one schema (1001 existing)`	`103` ms	`101` ms	`1.02`
`Update one schema (10001 existing)`	`1080` ms	`793` ms	`1.36`
`Cached rebuild (1 existing)`	`12` ms	`8` ms	`1.50`
`Cached rebuild (101 existing)`	`16` ms	`11` ms	`1.45`
`Cached rebuild (1001 existing)`	`43` ms	`37` ms	`1.16`
`Cached rebuild (10001 existing)`	`343` ms	`282` ms	`1.22`
`Index 100 schemas`	`445` ms	`524` ms	`0.85`
`Index 1000 schemas`	`1413` ms	`1586` ms	`0.89`
`Index 10000 schemas`	`12783` ms	`16630` ms	`0.77`
`Index 10000 schemas (custom meta-schema)`	`14896` ms	`16491` ms	`0.90`
`Index 10000 schemas ($ref fan-out)`	`15285` ms	`16950` ms	`0.90`
`test/e2e/html: Schema Fetch (p50)`	`395` us	`301` us	`1.31`
`test/e2e/html: Schema Fetch (p99)`	`477` us	`351` us	`1.36`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (enterprise)

Details

Benchmark suite	Current: `8dc48ab`	Previous: `e85241d`	Ratio
`Add one schema (0 existing)`	`289` ms	`341` ms	`0.85`
`Add one schema (100 existing)`	`104` ms	`115` ms	`0.90`
`Add one schema (1000 existing)`	`168` ms	`186` ms	`0.90`
`Add one schema (10000 existing)`	`925` ms	`802` ms	`1.15`
`Update one schema (1 existing)`	`100` ms	`108` ms	`0.93`
`Update one schema (101 existing)`	`109` ms	`118` ms	`0.92`
`Update one schema (1001 existing)`	`165` ms	`179` ms	`0.92`
`Update one schema (10001 existing)`	`879` ms	`825` ms	`1.07`
`Cached rebuild (1 existing)`	`11` ms	`12` ms	`0.92`
`Cached rebuild (101 existing)`	`14` ms	`15` ms	`0.93`
`Cached rebuild (1001 existing)`	`38` ms	`51` ms	`0.75`
`Cached rebuild (10001 existing)`	`295` ms	`305` ms	`0.97`
`Index 100 schemas`	`412` ms	`636` ms	`0.65`
`Index 1000 schemas`	`1476` ms	`1504` ms	`0.98`
`Index 10000 schemas`	`12964` ms	`14122` ms	`0.92`
`Index 10000 schemas (custom meta-schema)`	`15864` ms	`15801` ms	`1.00`
`Index 10000 schemas ($ref fan-out)`	`15733` ms	`17213` ms	`0.91`
`enterprise/e2e/auth: Schema Anonymous (p50)`	`291` us	`400` us	`0.73`
`enterprise/e2e/auth: Schema Anonymous (p99)`	`395` us	`518` us	`0.76`
`enterprise/e2e/auth: Schema API Key Identity (p50)`	`294` us	`405` us	`0.73`
`enterprise/e2e/auth: Schema API Key Identity (p99)`	`372` us	`513` us	`0.73`
`enterprise/e2e/auth: Schema API Key SHA256 (p50)`	`300` us	`412` us	`0.73`
`enterprise/e2e/auth: Schema API Key SHA256 (p99)`	`366` us	`526` us	`0.70`
`enterprise/e2e/auth: Schema JWT (p50)`	`410` us	`537` us	`0.76`
`enterprise/e2e/auth: Schema JWT (p99)`	`517` us	`685` us	`0.75`
`test/e2e/html: Schema Fetch (p50)`	`297` us	`408` us	`0.73`
`test/e2e/html: Schema Fetch (p99)`	`355` us	`499` us	`0.71`

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

augmentcode · 2026-09-30T14:01:37Z

🤖 Augment PR Summary

Summary: This PR changes collection resolve entries to name schema files rather than precomputed registry URIs.

Changes:

Documents file-target resolution and updates examples and end-to-end configurations.
Adds rebase_resolve_targets before indexing to translate target files to served URIs.
Validates missing, directory, unmounted, ambiguous, and non-schema targets with dedicated errors.
Factors schema identity calculation out of Resolver::add for reuse during rebasing.
Adds CLI coverage for valid file targets and several target-validation failures.

Technical notes: Relative targets are resolved from the declaring configuration file and must correspond to schemas served by a mounted collection.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-09-30T14:01:39Z

+          continue;
+        }
+
+        if (owner != nullptr) {


This treats a target as ambiguous before considering whether a candidate collection ignores it. A file under overlapping collections that is ignored by all but one is indexed only once and has a single served URI, but this now rejects that valid target instead of routing it to the collection that actually serves it.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-09-30T14:01:39Z

+
+      // A target the collection ignores is never indexed, so there is no URI
+      // to route the reference to
+      if (owner == nullptr ||


Ownership validation checks ignore but not the collection's extension filter. A target can therefore be rebased to a URI even though discovery skips that file (for example, a .json target in a collection configured for .schema.json), leaving every reference through this mapping unresolved during indexing.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

cubic-dev-ai

1 issue found across 23 files

_{You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/cli/index/community/snapshot-no-self-collection-resolve-file-target.clitest">

<violation number="1" location="test/cli/index/community/snapshot-no-self-collection-resolve-file-target.clitest:116">
P2: This snapshot checks only that both schemas' artifact paths exist, so it passes even if `urn:example:shared` never resolves. Assert that `uses`' dependency output contains the edge to `shared`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-09-30T14:02:18Z

+./version.json
+EOF
+
+COMPARE manifest.txt AGAINST expected.txt


P2: This snapshot checks only that both schemas' artifact paths exist, so it passes even if urn:example:shared never resolves. Assert that uses' dependency output contains the edge to shared.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At test/cli/index/community/snapshot-no-self-collection-resolve-file-target.clitest, line 116: <comment>This snapshot checks only that both schemas' artifact paths exist, so it passes even if `urn:example:shared` never resolves. Assert that `uses`' dependency output contains the edge to `shared`.</comment> <file context> @@ -0,0 +1,116 @@ +./version.json +EOF + +COMPARE manifest.txt AGAINST expected.txt </file context>

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai

2 issues found across 11 files (changes from recent commits).

_{You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/cli/index/common/fail-resolve-target-not-a-schema.clitest">

<violation number="1" location="test/cli/index/common/fail-resolve-target-not-a-schema.clitest:7">
P2: This fixture can fail during ordinary collection ingestion, independently of the `resolve` entry, so it does not verify that resolving this target rejects a non-schema. Isolate the target from automatic collection ingestion so the test catches regressions in resolve-target validation.</violation>
</file>

<file name="test/unit/resolver/resolver_test.cc">

<violation number="1" location="test/unit/resolver/resolver_test.cc:704">
P2: This expectation blesses a broken reference: `/example/...` resolves outside the resolver's `/v1/catalog` prefix. Keep the target under that prefix, or make rebasing use the resolver's server URL.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-09-30T14:26:11Z

+{ "$schema": "https://json-schema.org/draft/2020-12/schema" }
+EOF
+
+WRITE schemas/notes.json UNTIL EOF


P2: This fixture can fail during ordinary collection ingestion, independently of the resolve entry, so it does not verify that resolving this target rejects a non-schema. Isolate the target from automatic collection ingestion so the test catches regressions in resolve-target validation.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At test/cli/index/common/fail-resolve-target-not-a-schema.clitest, line 7: <comment>This fixture can fail during ordinary collection ingestion, independently of the `resolve` entry, so it does not verify that resolving this target rejects a non-schema. Isolate the target from automatic collection ingestion so the test catches regressions in resolve-target validation.</comment> <file context> @@ -4,8 +4,8 @@ WRITE schemas/sample.json UNTIL EOF -WRITE schemas/notes.txt UNTIL EOF -This file is not a schema +WRITE schemas/notes.json UNTIL EOF +[ "not a schema" ] EOF </file context>

cubic-dev-ai · 2026-09-30T14:26:11Z

    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "$id": "http://localhost:8000/v1/catalog/example/2020-12-ref-needs-rebase",
-    "$ref": "/v1/catalog/example/2020-12-with-id"
+    "$ref": "/example/2020-12-with-id"


P2: This expectation blesses a broken reference: /example/... resolves outside the resolver's /v1/catalog prefix. Keep the target under that prefix, or make rebasing use the resolver's server URL.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At test/unit/resolver/resolver_test.cc, line 704: <comment>This expectation blesses a broken reference: `/example/...` resolves outside the resolver's `/v1/catalog` prefix. Keep the target under that prefix, or make rebasing use the resolver's server URL.</comment> <file context> @@ -698,7 +701,7 @@ TEST(path_url_ref_needs_rebase) { "$schema": "https://json-schema.org/draft/2020-12/schema", "$id": "http://localhost:8000/v1/catalog/example/2020-12-ref-needs-rebase", - "$ref": "/v1/catalog/example/2020-12-with-id" + "$ref": "/example/2020-12-with-id" })JSON"); } </file context>

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Resolve schema collection references by file, as the JSON Schema CLI …

97ecdc3

…does Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

github-actions Bot reviewed Sep 29, 2026

View reviewed changes

jviotti added 4 commits September 30, 2026 10:29

Simpler

b1b2ee4

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Fix

7dc3dcc

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

More

627eb7f

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

More

30068e0

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti marked this pull request as ready for review September 30, 2026 13:58

augmentcode Bot reviewed Sep 30, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

jviotti added 2 commits September 30, 2026 11:21

Fix

1a0fa65

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Nicer

f6adeca

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

More

8dc48ab

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti merged commit 598fa7d into main Sep 30, 2026
6 checks passed

jviotti deleted the resolve-unify branch September 30, 2026 15:03

Conversation

jviotti commented Sep 29, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark (community)

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark (enterprise)

Uh oh!

augmentcode Bot commented Sep 30, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jviotti commented Sep 29, 2026 •

edited by cubic-dev-ai Bot

Loading

github-actions Bot left a comment •

edited

Loading

github-actions Bot left a comment •

edited

Loading

augmentcode Bot Sep 30, 2026 •

edited

Loading

augmentcode Bot Sep 30, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading