Add photo-first layouts, more image formats and better downloads - #13
Open
rodneyosodo wants to merge 9 commits into
Open
rodneyosodo wants to merge 9 commits into
rodneyosodo wants to merge 9 commits into
Conversation
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making a pinout leaf from a photo used to mean guessing
width,heightand image offsets until the pins lined up. This PR adds a second way to do it: start from the photo and click where the headers are. The existing grid config still works exactly as before; I checked that all existing boards produce the same SVGs byte for byte.Photo-first layouts
Use
headersinstead ofwidth/height/offsets/pins. Each header is its first and last hole in image pixels, and the holes in between are spaced evenly. The scale comes from the pin pitch (2.54 mm by default), so the output still prints at real size.rows: 2plusrowStart/rowEnd. Pin numbering is set withorder(zigzag,rowsoraround).pitch,count,side, andnullto skip a hole.Images
HTTP 404).Editor
grayscale/opacityinto the YAML, touching only those lines, so comments and formatting are left alone.Testing
Known limitation
In the browser, a non-PNG/JPEG image from a host that doesn't allow cross-origin requests can't be embedded, because the embed service only handles PNG/JPEG. It's linked instead, and the editor says so. The CLI doesn't have this problem.