add revision troubleshooting - #41
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e665038836
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!status && (commit_errno == EPROTOTYPE || | ||
| commit_errno == EPROTONOSUPPORT || commit_errno == ENOENT)) | ||
| diagnose_revision4(handle, diagnostic, diagnostic_length); | ||
| iptc_free(handle); |
There was a problem hiding this comment.
On every successful IPv4 commit, iptc_commit already consumes and frees the handle, so this unconditional iptc_free double-frees it and can crash or corrupt the process; the same defect exists for IPv6 at line 1137. The previous managed IptcInterface.Commit path explicitly treated successful commits as consuming the handle and freed it only after failure, so these wrappers should likewise call iptc_free/ip6tc_free only when status is false.
AGENTS.md reference: AGENTS.md:L36-L36
Useful? React with 👍 / 👎.
1 participant
No description provided.