Conversation
|
Just some quick feedback after a first glance, a detailed review will follow from the collegues responsible for your domain :) |
| FetchInstance: a.GetApplication(ctx, projectID, environmentID, applicationID).Execute, | ||
| GetState: getApplicationState, | ||
| ActiveState: []sca.CurrentStatus{sca.CURRENTSTATUS_CURRENT_STATUS_RUNNING, sca.CURRENTSTATUS_CURRENT_STATUS_IDLE}, | ||
| // ErrorState: []sca.CurrentStatus{sca.CURRENTSTATUS_CURRENT_STATUS_FAILED}, |
There was a problem hiding this comment.
Why is the ErrorState commented out?
There was a problem hiding this comment.
TLDR: during startup, the API reports an error state but it is able to recover from it.
An Application is essentially a Kubernetes deployment, so we use deployment conditions to check for availability. In some cases during the startup phase, we aren't handling these conditions correctly, which results in a transient failed status. We are working on a fix and plan to open a new PR that includes additional features. As we are still in beta, we are continuing to identify and address these edge cases.
There was a problem hiding this comment.
I understand, since you are even on alpha I would say it's fine for now. But please fix it until beta because otherwise it becomes difficult for the integration in the Tools (Terraform, CLI, Pulumi) since they are using this waiter. When the create or update fails, the waiter doesn't detect it at the moment because it doesn't know any error states. The only option that the waiter stops during a failed create / update is the timeout, which is at the moment 45 minutes. This means if in the first 5 minutes it's already clear that the application failed, the tools still continue to wait 40 minutes until they hit the timeout.
Can you add a comment to this line that there is this issue at the moment and that it will be fixed until your service is in beta?
Description
JIRA issue: https://jira.schwarz/browse/SCA-231
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)