fix(deps): protect owned destination files - #45
Merged
Merged
Conversation
Signed-off-by: Joe Beda <joe@stacklok.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
deps importguarded its destination using the broad provenance-prefix classifier. A locally owned model with an unknown reserved-prefix comment such as# modelith-note: ...was therefore treated as a malformed vendored copy and could be overwritten.Fix
Replacement now requires the existing provenance header to identify an origin and path for the same source. A malformed header that still identifies that source remains repairable. An unidentified header blocks import and directs the user to choose another directory or deliberately move/delete the existing file.
Verification
task checkpasses.Found while auditing the merged vendoring slice; the behavior existed in slice 2 rather than being introduced by the later refresh work.