Repository navigation
Honor multi-valued claims in vMCP authz - #6748
Open
lorenzozanee wants to merge 2 commits into
Open
lorenzozanee wants to merge 2 commits into
lorenzozanee wants to merge 2 commits into
Conversation
Signed-off-by: lorenzozanee <wyz0707@proton.me>
lorenzozanee
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
October 3, 2026 04:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6748 +/- ##
==========================================
+ Coverage 79.30% 79.34% +0.04%
==========================================
Files 802 802
Lines 81245 81248 +3
==========================================
+ Hits 64428 64468 +40
+ Misses 16812 16775 -37
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sanskarzz
self-requested a review
October 4, 2026 09:02
Collaborator
|
@lorenzozanee Please fix the CI failures before we proceed with the review. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multi_valued_claimsis accepted byMCPAuthzConfigbut dropped on theVirtualMCPServerpath, so Cedar never creates the configuredclaimset_*attribute and policies that use it deny requests.Fixes #6737
Type of change
Test plan
task test)task test-e2e)task lint-fix)gofmt -don changed Go files,git diff --check, YAML parsing, and CRD schema field checksThe focused command
go test ./cmd/thv-operator/pkg/vmcpconfig ./pkg/vmcp/auth/factorydid not reach compilation becauseproxy.golang.orgtimed out fetching dependencies. No functional/manual test is claimed.API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Changes
multi_valued_claimsinto Cedar options.Does this introduce a user-facing change?
Yes.
VirtualMCPServerauthorization can use configured multi-valued JWT claims as Cedar set attributes.Special notes for reviewers
CONTRIBUTING.mdasks contributors to claim an issue and wait for assignment before starting. Issue multi_valued_claims in MCPAuthzConfig is silently ignored for VirtualMCPServer #6737 was unassigned during this work; maintainer confirmation is needed before merge.