chore: migrate CI from Zuul to GitHub Actions - #29
Merged
Merged
Conversation
The eco2 jobs fail before reaching the code: the rust pre-run in zuul-infra references a missing ensure-rust role, and the builder node is unreachable. Build the image on pull requests and push change_<pr>_latest on merge instead, then drop zuul.yaml.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+17
to
+33
| if: github.event.pull_request.merged != true | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Build image | ||
| uses: docker/build-push-action@v7 | ||
| with: | ||
| context: . | ||
| target: metrics-processor | ||
| push: false | ||
|
|
||
| push_if_merged: |
Comment on lines
+35
to
+57
| if: github.event.pull_request.merged == true | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Login to Container Registry | ||
| uses: docker/login-action@v4 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ secrets.REGISTRY_USER }} | ||
| password: ${{ secrets.REGISTRY_PASSWORD }} | ||
|
|
||
| - name: Build and push | ||
| uses: docker/build-push-action@v7 | ||
| with: | ||
| context: . | ||
| target: metrics-processor | ||
| push: true | ||
| tags: ${{ env.IMAGE }}:change_${{ github.event.pull_request.number }}_latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Zuul check/gate with GitHub Actions.
Zuul's
eco2jobs have been failing before they reach any code:rust-build/rust-test: the rust pre-run inzuul-infra@mainreferencesensure-rust, which does not exist in that repository, so the pre-run aborts and the jobs end asRETRY_LIMIT.cloudmon-metrics-processor-build-image: its nodesetzuul-debian-builderis unreachable (ssh: Could not resolve hostname builder), so the job ends asRESULT_UNREACHABLE.eco2/checkwas the only required status check onmain, so every pull request was blocked regardless of its content.