Repository navigation
[6.x] Forms 2: Prefix internal submission keys with an underscore - #15637
Merged
Merged
Conversation
Store partial and site as _partial and _site so they're visibly internal and can't collide with form field handles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
values() returns the submission data without underscore-prefixed internal keys. The AJAX form success response used data(), which exposed them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ions The partial condition no longer refers to the internal key, and Antlers drops underscore-prefixed params so _partial can't be used either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jasonvarga
added a commit
that referenced
this pull request
Oct 12, 2026
Brings in #15637's underscore-prefixed internal keys. Spam now uses _spam: it's carried over by the data setter and used in whereStatus(), and the tag's queryStatus() no longer yields to partial:* or spam:* conditions, since Antlers drops underscore-prefixed params. Tests updated to the prefixed keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submissions store their internal lifecycle metadata (
partial,site) inline in their data. This renames those keys to_partialand_siteso they're visibly internal and can't collide with form field handles. Neither key exists on a released version, so there's nothing to migrate.asPartial(),isPartial(),finalize(),site()andwhereStatus()use the new keys.where('site', $handle)still works since it resolves throughsite().Submission::values(), which returns the data without_-prefixed keys (_partial,_site,_fake).data()is untouched, so writes through it still persist.values()rather thandata(), so internal keys aren't exposed to visitors. Webhooks, exporters, emails and augmentation already only output blueprint fields.{{ form:submissions }}only skips its finalized-only default forstatus:conditions. The oldpartial:check no longer refers to anything, and Antlers drops_-prefixed params so_partial:isn't usable either. A user field namedpartialno longer disables the default.partialandsiteare now usable as form field handles. Handles starting with_were already rejected by theHandlerule; this is now covered by a test.values()isn't added to theSubmissioncontract, as that would break direct implementers.The eloquent driver will need to mirror the
_partial/_sitekeys inwhereStatusand its site queries.