test: migrate stats/base/dists/hypergeometric/skewness to ULP-based assertions - #15046
Merged
kgryte merged 1 commit intoSep 7, 2026
Merged
Conversation
… assertions Replaces relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The maximum observed ULP difference over the fixture set is 1 for both the JavaScript and native implementations, so 1 is the minimum bound which passes. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132ozAreeH8GYagxGFNNVvX
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
September 7, 2026 09:59
kgryte
deleted the
kgryte/ulp-stats-base-dists-hypergeometric-skewness
branch
September 7, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/hypergeometric/skewnessfrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tol/EPStolerance arithmetic intest/test.jsandtest/test.native.jswithisAlmostSameValue( y, expected[ i ], 1 ), adding the@stdlib/assert/is-almost-same-valuerequire and dropping the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.Only the two test files are changed; no source, fixture, or package metadata was touched.
ULP bound
The final ULP constant is 1 for both
test/test.jsandtest/test.native.js, and this is the measured minimum:test/fixtures/julia/data.json), 66 values are bit-for-bit exact and the remaining 34 differ by exactly 1 ULP. The maximum observed ULP difference is therefore 1, for both the JavaScript and the native (C addon) implementations.0fails 34 of the 120 assertions intest/test.js, confirming 1 is the minimum bound which passes.test.js: 120/120,test.native.js: 108/108), so there is no FMA/arch-dependent flakiness at this bound.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Opened as a draft.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, unattended run over #11352. The ULP bound was measured empirically against the fixture set rather than guessed.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_0132ozAreeH8GYagxGFNNVvX
Generated by Claude Code