Skip to content

test: migrate stats/base/dists/laplace/skewness to ULP-based assertions - #15049

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
aryan7071:test-migrate-laplace-skewness-ulp
Sep 7, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
aryan7071:test-migrate-laplace-skewness-ulp

Conversation

@aryan7071

Copy link
Copy Markdown
Contributor

Resolves a part of #11352

Description

What is the purpose of this pull request?

This pull request:

  • migrates the test suite for stats/base/dists/laplace/skewness from relative tolerance (EPS/delta/tol) assertions to ULP difference assertions using @stdlib/assert/is-almost-same-value.
  • updates test/test.js and test/test.native.js. No other files are changed.
  • removes the now-unused EPS and abs imports and the corresponding delta/tol variable declarations from each file.
  • the ULP bound was verified directly against the fixture data using a script that computes the actual ULP distance between computed and expected values for every input. Verified minimum: 1 (all fixture values matched exactly on both JS and native, confirmed by running the verification against both implementations).

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@aryan7071
aryan7071 requested a review from a team September 6, 2026 19:58
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 6, 2026
@stdlib-bot

stdlib-bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Sep 7, 2026
Comment thread lib/node_modules/@stdlib/stats/base/dists/laplace/skewness/test/test.native.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte merged commit e2f9601 into stdlib-js:develop Sep 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5 Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants