Conversation
… assertions Replace relative tolerance assertions with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of 1 ULP across all fixture sets for the main, factory, and native implementations. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJKn4dpTUjRm6CFGRXBkdh --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/discrete-uniform/logpmffrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolrelative error computations (previouslytol = 1.0 * EPS * abs( expected[ i ] )) withisAlmostSameValue( y, expected[ i ], 1 )assertions from@stdlib/assert/is-almost-same-value, and drops the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsimports.test/test.logpmf.js,test/test.factory.js, andtest/test.native.js.test/test.jsis unchanged, as it contains no tolerance-based assertions.Final ULP constant:
1ULP, used uniformly across all three test files and all three fixture sets (small_range,medium_range,large_range).Measured minimum. The bound was tightened agentically rather than guessed. Starting from a high bound and lowering it, the minimum ULP difference required to pass the full fixture set (3 × 1000 cases) is
1for every implementation:lib/main.jslib/factory.jslib/native.jssmall_rangemedium_rangelarge_range1is the tightest integer bound that holds: re-running the suite with0ULP produces 607 failures, so the bound cannot be lowered further.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed:
make test TESTS_FILTER=".*/stats/base/dists/discrete-uniform/logpmf/.*"is green: 3017 (test.factory.js) + 3011 (test.logpmf.js) + 3 (test.js) + 3006 (test.native.js) assertions passing, 0 failing.make install-node-addons NODE_ADDONS_PATTERN="discrete-uniform/logpmf") so thattest.native.jswas actually exercised at 1 ULP rather than skipped.make lint-javascript-fileswithetc/eslint/.eslintrc.tests.jsis clean, and the full pre-commit static analysis report passes.One note on local tooling: the
lint_editorconfigpre-commit task could not run in this environment, becauseeditorconfig-checkerdownloads its binary from GitHub releases and the network egress available here blocks that fetch. The applicable EditorConfig rules for*.jswere instead verified directly on the changed files (LF endings, UTF-8, tab indentation, no trailing whitespace, final newline present); CI will run the real check.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied previously merged conversions in the same family (notably
stats/base/dists/discrete-uniform/logcdf) to match the established idiom, applied the mechanical substitution, and then determined the minimum ULP bound empirically by running the test suite across candidate bounds.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01FJKn4dpTUjRm6CFGRXBkdh
Generated by Claude Code