Skip to content

test: migrate blas/base/csrot to ULP-based assertions #15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kgryte wants to merge 1 commit into
base: develop
Choose a base branch
from
+68 −104
Draft

test: migrate blas/base/csrot to ULP-based assertions #15890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 16 additions & 25 deletions lib/node_modules/@stdlib/blas/base/csrot/test/test.csrot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var csrot = require( './../lib/csrot.js' );


Expand All @@ -37,22 +36,14 @@ var csrot = require( './../lib/csrot.js' );
* @param {Object} t - test object
* @param {Collection} actual - actual values
* @param {Collection} expected - expected values
* @param {number} rtol - relative tolerance
* @param {NonNegativeInteger} ulp - maximum allowed ULP difference
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;
function isApprox( t, actual, expected, ulp ) {
var i;

t.strictEqual( actual.length, expected.length, 'returns expected value' );
for ( i = 0; i < expected.length; i++ ) {
if ( actual[ i ] === expected[ i ] ) {
t.strictEqual( actual[ i ], expected[ i ], 'returns expected value' );
} else {
delta = abs( actual[ i ] - expected[ i ] );
tol = rtol * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. actual: '+actual[ i ]+'. expected: '+expected[ i ]+'. delta: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( isAlmostSameValuef( actual[ i ], expected[ i ], ulp ), true, 'returns expected value' );
}
}

Expand Down Expand Up @@ -125,8 +116,8 @@ tape( 'the function applies a plane rotation', function test( t ) {
]);

out = csrot( x.length, x, 1, y, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -186,8 +177,8 @@ tape( 'the function supports an `x` stride', function test( t ) {
]);

out = csrot( 2, x, 2, y, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -247,8 +238,8 @@ tape( 'the function supports a `y` stride', function test( t ) {
]);

out = csrot( 2, x, 1, y, 2, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -350,8 +341,8 @@ tape( 'the function supports negative strides', function test( t ) {
]);

out = csrot( 2, x, -1, y, -2, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -411,8 +402,8 @@ tape( 'the function supports complex access patterns', function test( t ) {
]);

out = csrot( 2, x, 2, y, -1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -479,8 +470,8 @@ tape( 'the function supports view offsets', function test( t ) {
]);

out = csrot( 2, x1, -2, y1, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y1, 'returns expected value' );
t.end();
});
41 changes: 16 additions & 25 deletions lib/node_modules/@stdlib/blas/base/csrot/test/test.csrot.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand All @@ -46,22 +45,14 @@ var opts = {
* @param {Object} t - test object
* @param {Collection} actual - actual values
* @param {Collection} expected - expected values
* @param {number} rtol - relative tolerance
* @param {NonNegativeInteger} ulp - maximum allowed ULP difference
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;
function isApprox( t, actual, expected, ulp ) {
var i;

t.strictEqual( actual.length, expected.length, 'returns expected value' );
for ( i = 0; i < expected.length; i++ ) {
if ( actual[ i ] === expected[ i ] ) {
t.strictEqual( actual[ i ], expected[ i ], 'returns expected value' );
} else {
delta = abs( actual[ i ] - expected[ i ] );
tol = rtol * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. actual: '+actual[ i ]+'. expected: '+expected[ i ]+'. delta: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( isAlmostSameValuef( actual[ i ], expected[ i ], ulp ), true, 'returns expected value' );
}
}

Expand Down Expand Up @@ -134,8 +125,8 @@ tape( 'the function applies a plane rotation', opts, function test( t ) {
]);

out = csrot( x.length, x, 1, y, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -195,8 +186,8 @@ tape( 'the function supports an `x` stride', opts, function test( t ) {
]);

out = csrot( 2, x, 2, y, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -256,8 +247,8 @@ tape( 'the function supports a `y` stride', opts, function test( t ) {
]);

out = csrot( 2, x, 1, y, 2, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -359,8 +350,8 @@ tape( 'the function supports negative strides', opts, function test( t ) {
]);

out = csrot( 2, x, -1, y, -2, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -420,8 +411,8 @@ tape( 'the function supports complex access patterns', opts, function test( t )
]);

out = csrot( 2, x, 2, y, -1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -488,8 +479,8 @@ tape( 'the function supports view offsets', opts, function test( t ) {
]);

out = csrot( 2, x1, -2, y1, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y1, 'returns expected value' );
t.end();
});
45 changes: 18 additions & 27 deletions lib/node_modules/@stdlib/blas/base/csrot/test/test.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var csrot = require( './../lib/ndarray.js' );


Expand All @@ -37,22 +36,14 @@ var csrot = require( './../lib/ndarray.js' );
* @param {Object} t - test object
* @param {Collection} actual - actual values
* @param {Collection} expected - expected values
* @param {number} rtol - relative tolerance
* @param {NonNegativeInteger} ulp - maximum allowed ULP difference
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;
function isApprox( t, actual, expected, ulp ) {
var i;

t.strictEqual( actual.length, expected.length, 'returns expected value' );
for ( i = 0; i < expected.length; i++ ) {
if ( actual[ i ] === expected[ i ] ) {
t.strictEqual( actual[ i ], expected[ i ], 'returns expected value' );
} else {
delta = abs( actual[ i ] - expected[ i ] );
tol = rtol * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. actual: '+actual[ i ]+'. expected: '+expected[ i ]+'. delta: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( isAlmostSameValuef( actual[ i ], expected[ i ], ulp ), true, 'returns expected value' );
}
}

Expand Down Expand Up @@ -125,8 +116,8 @@ tape( 'the function applies a plane rotation', function test( t ) {
]);

out = csrot( x.length, x, 1, 0, y, 1, 0, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -186,8 +177,8 @@ tape( 'the function supports an `x` stride', function test( t ) {
]);

out = csrot( 2, x, 2, 0, y, 1, 0, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -247,8 +238,8 @@ tape( 'the function supports an `x` offset', function test( t ) {
]);

out = csrot( 3, x, 1, 1, y, 1, 0, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -308,8 +299,8 @@ tape( 'the function supports a `y` stride', function test( t ) {
]);

out = csrot( 2, x, 1, 0, y, 2, 0, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -369,8 +360,8 @@ tape( 'the function supports a `y` offset', function test( t ) {
]);

out = csrot( 2, x, 2, 0, y, -1, 1, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -472,8 +463,8 @@ tape( 'the function supports negative strides', function test( t ) {
]);

out = csrot( 2, x, -1, 1, y, -2, 2, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -533,8 +524,8 @@ tape( 'the function supports complex access patterns', function test( t ) {
]);

out = csrot( 2, x, 2, 1, y, 1, 2, 0.8, 0.6 );
isApprox( t, viewX, xe, 2.0 );
isApprox( t, viewY, ye, 2.0 );
isApprox( t, viewX, xe, 0 );
isApprox( t, viewY, ye, 1 );
t.strictEqual( out, y, 'returns expected value' );
t.end();
});
Loading
Loading