Skip to content

fix: correct argument validation error messages in random/iter/frechet and random/iter/negative-binomial #15894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix: correct argument validation error messages in random/iter/frechet and random/iter/negative-binomial #15894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca2eab0
fix: update error message in `random/iter/frechet`
claude Oct 4, 2026
a8a2d67
fix: update error message in `random/iter/negative-binomial`
claude Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/random/iter/frechet/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
// MAIN //

/**
* Returns an iterator for generating pseudorandom numbers drawn from a Fr茅chet distribution.

Check warning on line 44 in lib/node_modules/@stdlib/random/iter/frechet/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "茅chet"
*
* @param {PositiveNumber} alpha - shape parameter
* @param {PositiveNumber} s - rate parameter
Expand Down Expand Up @@ -87,7 +87,7 @@
throw new TypeError( format( 'invalid argument. Second argument must be a positive number. Value: `%s`.', s ) );
}
if ( !isNumber( m ) || isnan( m ) ) {
throw new TypeError( format( 'invalid argument. Third argument must be a number. Value: `%s`.', m ) );
throw new TypeError( format( 'invalid argument. Third argument must be a number and not NaN. Value: `%s`.', m ) );
}
if ( arguments.length > 3 ) {
if ( !isObject( options ) ) {
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/random/iter/negative-binomial/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function iterator( r, p, options ) {
var FLG;
var i;
if ( !isPositiveNumber( r ) ) {
throw new TypeError( format( 'invalid argument. First argument must be a positive integer. Value: `%s`.', r ) );
throw new TypeError( format( 'invalid argument. First argument must be a positive number. Value: `%s`.', r ) );
}
if ( !isProbability( p ) ) {
throw new TypeError( format( 'invalid argument. Second argument must be a probability. Value: `%s`.', p ) );
Expand Down
Loading