Skip to content

itoa must be included explicitly #3084

Description

@Blake-Latchford

Describe the bug
Previously iota was included via Arduino.h via wiring.h. Now it must be included explicitly for use.

To Reproduce
This broke the WIO-E5 build in MeshCore
meshcore-dev/MeshCore#3436

Expected behavior
#include "Arduino.h" implicitly includes iota.

Desktop (please complete the following information):

  • OS: Pop! OS

Board (please complete the following information):
https://wiki.seeedstudio.com/LoRa_E5_mini/

Additional context
AI tells me that this change was made in the PR below, as part of what seems like a change that drove the major revision update to 3.0.0. A tiny part of a massive change makes me think this was an accident. There are a thousand reasons to consider this valid, and the impact downstream is modest. Feel free to resolve this issue as "won't fix"
https://github.com/stm32duino/Arduino_Core_STM32/pull/2879/changes#r4057700677

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions