Follow Storm 1.14.1: the scroll request states the ordering and size, the cursor the position - #2
Open
zantvoort wants to merge 1 commit into
Open
Follow Storm 1.14.1: the scroll request states the ordering and size, the cursor the position#2zantvoort wants to merge 1 commit into
zantvoort wants to merge 1 commit into
Conversation
…rsor the position Scrollable.fromCursor(key, cursor) is gone. The scroll request names its key and size in code, and from(cursor) puts it at the position a client sent back, so the page size no longer travels inside the cursor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storm 1.14.1 states a scroll request as an ordering, a size and a position:
Scrollable.fromCursor(key, cursor)is gone, andScrollable.of(key, size).from(cursor)puts the request at the position a client sent back, so the page size no longer travels inside the cursor. The search and browse services and the repository tests follow.Compiled, main and test sources, against the 1.14.1 build. Merge after the release bump to 1.14.1 lands on main, as with the 1.14.0 tracking branch.