Repository navigation
chore(deps): do not offer keyv or mermaid majors yet - #237
Merged
Merged
Conversation
The production group bumped keyv to 6.1.0 on its own. Both providers pass their Keyv stores to cache-manager, which still depends on keyv ^5.6 in its latest release, and @keyv/redis 6 - already held back for its own reasons - is the release that peers on keyv 6. Alone, the bump broke every redis purge (#234). keyv has to move together with cache-manager and @keyv/redis, as one deliberate migration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 7 tasks
…cost mermaid 12 clips the second line of our flowchart labels and is outside vitepress-plugin-mermaid's declared peer range. No CI job renders the docs, so #231 was green while visibly breaking them. The keyv comment said keyv 6 "no longer populates" opts.store; it has no opts at all. More importantly it implied the port was an accessor fix. It is not: keyv 6 bridges @keyv/redis 3 and drops the default namespace, which would turn purges into silent no-ops, and the @keyv/redis that supports it moves to @redis/client while the redis plugin is being rewritten. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@keyv/redis 4 and 5 already run on @redis/client and peer on keyv ^5, so the provider's move to node-redis (#239) can land without keyv 6. The previous comment implied the two had to move together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Dependabot's production group (#234) bumped
keyv5.6.0 → 6.1.0 on its own. The redis e2e suite failed on Node 22, 24 and 26 because every purge threw:That error comes from
RedisCacheProvider.ts:72, which readscache.stores[0].opts.store. keyv 6 has nooptsat all.Porting the provider isn't the fix yet:
Keyvstores tocache-manager'screateCache, andcache-manager7.2.9 (the latest) still depends onkeyv ^5.6.@keyv/redis6 is the release that peers onkeyv ^6.1, and its major is already ignored here because the provider relies on that adapter's internals (Purge enumerates the entire keyspace: ~30k Redis round trips and 55MB transferred to invalidate one content type #131, Purge Cache - Redis Cluster #100).Fixing the accessor wouldn't be enough either:
@keyv/redis3 in a bridge adapter and no longer defaults thekeyvnamespace.undefined:*. They would match nothing silently instead of failing.So moving to keyv 6 has to be a deliberate migration once
cache-managersupports it.This does not block the move to node-redis:
@keyv/redis4 and 5 already use@redis/clientand still peer on keyv ^5, so #239 (the plugin-redis v3 move) can land on keyv 5. Only@keyv/redis6 needs keyv 6. This addskeyvto the major-version ignore list next to@keyv/redis, with the reason.mermaid majors are ignored too:
look: 'classic'restores most of the old look but still clips.vitepress-plugin-mermaidonly declares support for mermaid 10 and 11.Once this is merged, #234 and #231 both need
@dependabot recreateso it's rebuilt without the keyv bump. Its other updates (Strapi 5.57, react-router-dom, styled-components) passed every other suite.Checklist
main.🤖 Generated with Claude Code