fix: harden sn-operator service account token mount - #117
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes implement the intended hardening with no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Hardens the operator service account token mounting with a secure default while preserving access for the operator pod.
Changes:
- Defaults service account token automounting to
false. - Explicitly enables token mounting for the operator deployment.
- Bumps the chart version to
0.20.2.
| File | Description |
|---|---|
charts/sn-operator/values.yaml |
Adds the token automount setting. |
charts/sn-operator/templates/sa.yaml |
Applies the setting to the ServiceAccount. |
charts/sn-operator/templates/deployment.yaml |
Enables token mounting for the operator pod. |
charts/sn-operator/Chart.yaml |
Updates the chart version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
labuladong
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serviceAccount.automountServiceAccountTokento the sn-operator charttrue0.20.1Refs streamnative/eng-support-tickets#4974.
Manual token mount example
The operator uses in-cluster Kubernetes API credentials. When disabling automatic token mounting, provide the projected token, cluster CA, and namespace at the standard in-cluster path:
Validation
helm lint charts/sn-operator