sharp fallback for favicon & social-card when ImageMagick is absent - #22
Open
raoulbia-ai wants to merge 1 commit into
Open
raoulbia-ai wants to merge 1 commit into
raoulbia-ai wants to merge 1 commit into
Conversation
…sent make-favicon and make-social-card previously required a magick/convert binary on PATH and failed hard without one. They now fall back to sharp/libvips, producing the identical output set: the favicon PNG set, a hand-assembled multi-resolution favicon.ico (16/32/48), the apple-touch-icon, and the 1200x630 social card with scrim + wrapped tagline. The ImageMagick path is unchanged when a binary is present; the fallback triggers only when none is found. sharp is already a project dependency.
👷 Deploy request for explainmyrepo pending review.Visit the deploys page to approve it
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3 for #19 (local, offline runs).
Add a
sharpfallback formake-faviconandmake-social-cardwhen ImageMagick is absent. Previously both required amagick/convertbinary onPATHand failed hard without one.favicon.ico(16/32/48), the apple-touch-icon, and the 1200×630 social card with scrim + wrapped tagline.sharpis already a project dependency.Tests:
tests/sharp-image-fallback.test.mjs(2, run with an emptyPATHto force the fallback; assert real PNGs, a valid multi-res ICO, and the 1200×630 card). Independent of the other two PRs for #19.